Closed
Bug 640274
Opened 14 years ago
Closed 14 years ago
rm {JS_,js_,}GetExternalStringGCType
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: luke, Assigned: luke)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
5.85 KB,
patch
|
brendan
:
review+
|
Details | Diff | Splinter Review |
This doesn't seem to be used anywhere in Mozilla. If it was used anywhere, I think it would immediately assert because GetExternalStringGCType does JS_ASSERT(IsFinalizableStringKind(str->externalStringType)) which seems bogus. Affects JSAPI, so r? brendan.
Attachment #518140 -
Flags: review?(brendan)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 518140 [details] [diff] [review] rm This probably worked once upon a time. It was added for completeness, but it seems like none of the embedding's business! /be
Attachment #518140 -
Flags: review?(brendan) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/55f83a052b61
Whiteboard: fixed-in-tracemonkey
|
||
Comment 3•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/55f83a052b61
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•