640407 - Update nsIURLFormatter to use the correct ABI for universal builds on OS X

Status: RESOLVED WONTFIX

(Toolkit :: General, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Right now calling the methods on nsIURLFormatter will result in a wrong BUILD_TARGET replacement. I have seen that while trying to build up the URL for the AUS update snippets.

Instead of 'Darwin_x86_64-gcc3-u-i386-x86_64' both methods return 'Darwin_Universal-gcc3'.

For the UpdateService is special code to handle that situation:
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/nsUpdateService.js#162

It should really be part of the formatting methods so no-one has to write code on his own to replace all those placeholders.

Comment 1

[Robert Strong (they/them - no direct email)]

The update service's usage is very much so update service specific and I kind of prefer it being in the update service so I don't have to worry about other consumers that don't want or need it in this format if I need to change it again in the future.

If this is implemented and the update service is expected to use it then the implementation must make it very clear that the value returned for this can change without notice to other consumers.

Comment 2

[Michael Shal [:mshal]]

We no longer do universal builds (bug 1295375).