640425 - Clicking on the searchbar engine dropdown makes the field lose focus

Status: RESOLVED FIXED

(SeaMonkey :: Search, defect)

Description

[Robert Kaiser]

Bug 401417 comment #45 by Neil:
I did notice one issue and that is that clicking on the button causes the
search field to lose focus. One workaround for that is to use a toolbarbutton
instead of a button.

Comment 1

[Stefan [:stefanh]]

Interestingly, it doesn't lose focus on Mac.

Comment 2

[[e-mail]]

Attachment: WIP

This also contains all the adjustments needed to get the search bar the same height as the URL bar in Modern and Classic (Windows/Linux). I notice the dropmarker doesn't look so good in Linux though, so this may not be final.

Comment 3

[[e-mail]]

Attachment: Possible patch

Comment 4

[Robert Kaiser]

(In reply to comment #1)
> Interestingly, it doesn't lose focus on Mac.

Not that I haven't even tested, only filed a bug because Neil noted it.

Comment 5

[Robert Kaiser]

Oh, and I hope you tested a11y with this patch, as I highly fear that not making it any kind of button makes it inaccessible.

Comment 6

[[e-mail]]

Probably because Mac's focus rules are weird. You would probably lose focus if you had turned on full keyboard access, or something.

Comment 7

[[e-mail]]

It becomes accessible once you've used it, which is a bit useless.

Comment 8

[[e-mail]]

Attachment: Hybrid approach

Comment 9

[Ian Neal]

Comment on attachment 519126 [details] [diff] [review]
Hybrid approach

r=me

Comment 10

[Stefan [:stefanh]]

(In reply to comment #1)
> Interestingly, it doesn't lose focus on Mac.

Ah, on Mac the problem is not that it doesn't lose focus when you click the drop-down, instead the problem is that if the field doesn't have focus, clicking the drop-down doesn't give the field focus (which it does in native Mac apps). The patch here doesn't change anything for me, though.

When clicking the urlbar history drop-down, the urlbar gets focused though.

Comment 11

[[e-mail]]

Pushed changeset 0129d8e79d1c to comm-central.