640429 - Preferences screen is cut off in portrait mode on Linux Desktop

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Alon Zakai (:azakai)]

Credit to wesj for noticing. After the patch landed to put us in portrait mode on desktop, if you go the the preferences screen, some of the content is cut off - you need to resize the window to make it wider, to see all the content.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

We sue 480 as the portrait width when switching back and forth:
http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser.js#127

and 480 is the width on several phone-sized devices.

500 is not enough to trigger some media query CSS rules. In this case the error console rule was not kicking in so the buttons were too wide for the given width, forcing an overflow. Resizing the window to less than 500 is enough to kick in the rule:

http://mxr.mozilla.org/mobile-browser/source/themes/core/browser.css#575

This patch simply sets the width to 480 and all is well

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to fix desktop releases:
http://hg.mozilla.org/mobile-browser/rev/4ef2c1aa65d8

Comment 3

[Ayan Shah[:ashah]]

Verified fix on Mozilla/5.0 (Android; Linux armv71; rv:2.0b13pre)
Gecko/20110317 Firefox/4.0b13pre Fennec/4.0b6pre.