Closed
Bug 640613
Opened 14 years ago
Closed 14 years ago
Chrome scrollbars stays visible if a context menu show up while panning
Categories
(Firefox for Android Graveyard :: Panning/Zooming, defect)
Firefox for Android Graveyard
Panning/Zooming
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: vingtetun, Assigned: vingtetun)
Details
Attachments
(1 file, 1 obsolete file)
|
3.82 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Steps to reproduce:
* have many entries into the "All Pages" of the awesome panel
* do a kinecti pan
* quickly tap and stay pressed on one entry
Actual result:
* a context menu show up and the vertical scrollbar is visible on the right side
Expected result:
* a context menu show up and the vertical scrollbar is gone
Attachment #518384 -
Flags: review?(mark.finkle)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 518384 [details] [diff] [review]
Patch
Should we add the "CancelTouchSequence" code to ContextHelper.showPopup ?
|
Assignee | |
Comment 2•14 years ago
|
||
(In reply to comment #1)
> Comment on attachment 518384 [details] [diff] [review]
> Patch
>
> Should we add the "CancelTouchSequence" code to ContextHelper.showPopup ?
Right, it could prevent spreading this code everywhere.
I just wonder if this make sense since ContextHelper.showPopup could be called outside of a touch sequence?
|
|
||
Comment 3•14 years ago
|
||
(In reply to comment #2)
> (In reply to comment #1)
> > Comment on attachment 518384 [details] [diff] [review]
> > Patch
> >
> > Should we add the "CancelTouchSequence" code to ContextHelper.showPopup ?
>
> Right, it could prevent spreading this code everywhere.
>
> I just wonder if this make sense since ContextHelper.showPopup could be called
> outside of a touch sequence?
The "CancelTouchSequence" handler should be prepared for that, imo
|
|
Assignee | |
Comment 4•14 years ago
|
||
Add the event to ContextHelper.showPopup
Assignee: nobody → 21
Attachment #518384 -
Attachment is obsolete: true
Attachment #518384 -
Flags: review?(mark.finkle)
Attachment #518428 -
Flags: review?(mark.finkle)
|
|
||
Comment 5•14 years ago
|
||
Comment on attachment 518428 [details] [diff] [review]
Patch v0.2
Can we add some a test in browser_scrollbar to test this?
Attachment #518428 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 6•14 years ago
|
||
http://hg.mozilla.org/mobile-browser/rev/cf2ab7ef1920
pushed with a test.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Comment 7•14 years ago
|
||
VERIFIED FIXED on:
Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:5.0a2) Gecko/20110413 Firefox/5.0a2 Fennec /5.0a
Device: HTC Desire Z (Android 2.2)
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•