Closed
Bug 640697
Opened 14 years ago
Closed 13 years ago
Pollers should stop polling after successful result
Categories
(Release Engineering :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: rail)
References
Details
Attachments
(1 file)
|
2.35 KB,
patch
|
catlee
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
FtpPoller (replaced by UrlPoller for releases) and LocalesFtpPoller don't start polling after getting successful poll result and under some conditions (stage returns 404 temporarily) may reset poller state and as a result the poller may trigger a new Change.
UrlPoller, which doesn't have this problem, could be used as an example.
|
Assignee | |
Comment 1•13 years ago
|
||
Stop the pollers in the following cases:
1) after first poll (buildbot start/restart) if the criterion matches.
2) after sending a change (return True)
To be tested in staging.
Attachment #545155 -
Flags: review?(catlee)
|
||
Updated•13 years ago
|
Attachment #545155 -
Flags: review?(catlee) → review+
|
|
Assignee | |
Updated•13 years ago
|
Priority: P5 → P2
|
|
Assignee | |
Comment 2•13 years ago
|
||
Comment on attachment 545155 [details] [diff] [review]
Stop pollers
http://hg.mozilla.org/build/buildbotcustom/rev/f3c42b61a16b
Attachment #545155 -
Flags: checked-in+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Worked fine in staging.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 4•13 years ago
|
||
Landed on production and reconfigured.
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•