Closed Bug 640697 Opened 9 years ago Closed 9 years ago

Pollers should stop polling after successful result

Categories

(Release Engineering :: General, defect, P2)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(1 file)

FtpPoller (replaced by UrlPoller for releases) and LocalesFtpPoller don't start polling after getting successful poll result and under some conditions (stage returns 404 temporarily) may reset poller state and as a result the poller may trigger a new Change.

UrlPoller, which doesn't have this problem, could be used as an example.
Attached patch Stop pollersSplinter Review
Stop the pollers in the following cases:

1) after first poll (buildbot start/restart) if the criterion matches.
2) after sending a change (return True)

To be tested in staging.
Attachment #545155 - Flags: review?(catlee)
Attachment #545155 - Flags: review?(catlee) → review+
Priority: P5 → P2
Worked fine in staging.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Landed on production and reconfigured.
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.