Closed
Bug 640719
Opened 13 years ago
Closed 13 years ago
JavaScript validation for filing bugs prevents creation of bookmarkable templates with blank mandatory fields (summary, component, etc.)
Categories
(Bugzilla :: Creating/Changing Bugs, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.0
People
(Reporter: mozilla, Assigned: mkanat)
Details
(Keywords: regression)
Attachments
(1 file)
1.18 KB,
patch
|
guy.pyrzak
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.15) Gecko/20110303 Firefox/3.6.15 (.NET CLR 3.5.30729) Build Identifier: The JS implemented in bug 490767 is attached to the "Remember values as bookmarkable template" button, but nothing should be mandatory for a template. This prevents the creation of templates with empty summaries, unspecified components, or empty descriptions. Reproducible: Always
Comment 1•13 years ago
|
||
Confirmed.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking4.0.1+
Keywords: regression
Target Milestone: --- → Bugzilla 4.0
Version: unspecified → 4.0
Assignee | ||
Comment 2•13 years ago
|
||
Simple enough to fix. :-) (Small patch.)
Assignee: create-and-change → mkanat
Status: NEW → ASSIGNED
Attachment #526541 -
Flags: review?(reed)
Attachment #526541 -
Flags: review?(guy.pyrzak)
Comment 3•13 years ago
|
||
Comment on attachment 526541 [details] [diff] [review] v1 Review of attachment 526541 [details] [diff] [review]: works for me. I'd prefer to pass in a variable, but since we're using onsubmit for the form i can't think of a better way to handle this.
Attachment #526541 -
Flags: review?(guy.pyrzak) → review+
Reporter | ||
Comment 4•13 years ago
|
||
I just applied the patch on our installations, and it works great. Thanks!
Assignee | ||
Updated•13 years ago
|
Flags: approval4.0+
Flags: approval+
Assignee | ||
Updated•13 years ago
|
Attachment #526541 -
Flags: review?(reed)
Assignee | ||
Comment 5•13 years ago
|
||
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/ modified js/field.js modified template/en/default/bug/create/create.html.tmpl Committed revision 7794. Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/ modified js/field.js modified template/en/default/bug/create/create.html.tmpl Committed revision 7580.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•13 years ago
|
Flags: testcase?
You need to log in
before you can comment on or make changes to this bug.
Description
•