Closed
Bug 640889
Opened 12 years ago
Closed 12 years ago
[Firefox] WinXP debug permaorange: "test_leaf_layers_partition_browser_window.xul | Leaf layers should form a non-overlapping partition of the browser window"
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: philor, Assigned: roc)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [perma-orange])
Attachments
(2 files)
1.59 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
3.75 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1299774157.1299777108.3542.gz&fulltext=1#err0 Rev3 WINNT 5.1 mozilla-central debug test mochitest-other on 2011/03/10 08:22:37 s: talos-r3-xp-020 ... 7556 INFO TEST-PASS | chrome://mochitests/content/chrome/layout/base/test/chrome/test_leaf_layers_partition_browser_window.xul | Waiting for mozPaintCount to increase. - 0 should equal 0 7557 INFO TEST-PASS | chrome://mochitests/content/chrome/layout/base/test/chrome/test_leaf_layers_partition_browser_window.xul | mozPaintCount has increased - 1 should not equal 0 7558 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/base/test/chrome/test_leaf_layers_partition_browser_window.xul | Leaf layers should form a non-overlapping partition of the browser window No idea how to tell whether or not this is the same thing as bug 632408, where it permafails on SeaMonkey's (debug-only) Win2K3 boxes.
Comment 1•12 years ago
|
||
roc and tnikkel could we disable this test so we can unhide the whole suite? I would like to reveal the suite while we figure out how to fix this test failure.
Updated•12 years ago
|
Blocks: 632408
Summary: WinXP debug permaorange: test_leaf_layers_partition_browser_window.xul | Leaf layers should form a non-overlapping partition of the browser window → [Firefox] WinXP debug permaorange: "test_leaf_layers_partition_browser_window.xul | Leaf layers should form a non-overlapping partition of the browser window"
Comment 2•12 years ago
|
||
Bug 632408 comment 5: { Timothy Nikkel (:tn) 2011-03-11 02:11:18 PST If you set the environment variable MOZ_DUMP_PAINT_LIST to 1 you will get a lot of paint debug output including a dump of the layer tree. The layer tree dump would probably useful in determining why this is failing. }
Keywords: qawanted
Whiteboard: [perma-orange] → [qaw: comment 2] [perma-orange]
Comment 3•12 years ago
|
||
So the reason this fails is that the resizer has a layer that overlaps the content layer. Windows Vista/7 resize via a thick border and don't have the resizer.
Whiteboard: [qaw: comment 2] [perma-orange] → [perma-orange]
Comment 4•12 years ago
|
||
Since on both XP and Vista/7 our browser window has significant differences we should probably run the test twice, once with a maximized window and once without. (XP has a resizer only when not maximized, and the tabs move up higher on a maximized window on Vista/7.)
Comment 5•12 years ago
|
||
The resizer layer is 17x17, so I don't think we have a problem here. The question is how to modify the test properly.
Reporter | ||
Comment 6•12 years ago
|
||
This'll keep me from constantly badgering you about when you'll figure out a way to deal with the resizer, and when I can make the suite visible, and when you're going to work on it, and how the work on it is going, and whether you've come up with an idea yet, and when...
Attachment #518996 -
Flags: review?(tnikkel)
Updated•12 years ago
|
Attachment #518996 -
Flags: review?(tnikkel) → review+
Reporter | ||
Comment 7•12 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/a7c8c8e4d928
Keywords: qawanted
Assignee | ||
Comment 8•12 years ago
|
||
(In reply to comment #5) > The resizer layer is 17x17, so I don't think we have a problem here. The > question is how to modify the test properly. Let's just not run the non-fullscreen test on < Vista.
Comment 9•12 years ago
|
||
Is there an (easy) way to maximize a window? I spent some time looking but failed to find a way.
Reporter | ||
Comment 10•12 years ago
|
||
http://mxr.mozilla.org/mozilla-central/source/widget/tests/window_state_windows.xul#99 seems to say "get it through nsIWindowMediator, then call win.maximize()"
Comment 11•12 years ago
|
||
Thanks Phil!
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Comment 21•12 years ago
|
||
Breathing room on 2.0: http://hg.mozilla.org/releases/mozilla-2.0/rev/a540041afe0a
Comment 22•12 years ago
|
||
There were a couple of green mozilla2.0 cycles before this landed (despite summary claiming permaorange), and since then we've seen bug 637975 as a perma-orange
Reporter | ||
Comment 23•12 years ago
|
||
Excuse me? Neither one of those assertions seems to be at all true. Log links or it didn't happen.
Reporter | ||
Comment 24•12 years ago
|
||
http://dev.philringnalda.com/tbpl48/?tree=Firefox4.0&rev=a540041afe0a (http://dev.philringnalda.com/tbpl48/plus48)
Comment 25•12 years ago
|
||
The same failure is showing up on Tracemonkey for OS X debug. Is this the same/related? Or is it real, from http://hg.mozilla.org/tracemonkey/rev/673f93bb84aa ? http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1305237018.1305240745.26115.gz http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1305232257.1305236004.29696.gz http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1305229759.1305233623.15447.gz http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1305235915.1305239745.20694.gz
Assignee | ||
Comment 26•12 years ago
|
||
Attachment #532599 -
Flags: review?(tnikkel)
Assignee | ||
Comment 27•12 years ago
|
||
(In reply to comment #25) Looks like mrbkap backed some stuff out to fix those failures.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → roc
Updated•12 years ago
|
Attachment #532599 -
Flags: review?(tnikkel) → review+
Assignee | ||
Updated•12 years ago
|
Whiteboard: [perma-orange] → [perma-orange][needs landing]
Comment 28•12 years ago
|
||
Pushed once: http://hg.mozilla.org/mozilla-central/rev/c0f9a84ffb2d Then backed out because the bug number was incorrect: http://hg.mozilla.org/mozilla-central/rev/1205e0437f0a Then pushed again: http://hg.mozilla.org/mozilla-central/rev/f792fa7755dc
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [perma-orange][needs landing] → [perma-orange]
Target Milestone: --- → mozilla6
You need to log in
before you can comment on or make changes to this bug.
Description
•