Closed Bug 640945 Opened 9 years ago Closed 9 years ago

Don't use dated snippet directory names

Categories

(Release Engineering :: General, defect, P2)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

References

Details

(Whiteboard: [releases][automation])

Attachments

(2 files)

It's very hard to predict the names or use them in automation
But we still need something to make the names unique, of only because of build2 and so on. Any suggestions ?
Attached patch snippet dir nameSplinter Review
Nick, what do you think about this? The dir names are not unique per invocation but per build number.
Attachment #519055 - Flags: feedback?(nrthomas)
Comment on attachment 519055 [details] [diff] [review]
snippet dir name

Looks like it would work for when we have no problems with the automation or app. 

What would the workflow be if we have to manually tweak the snippets ? I don't want to overwrite any existing directory, that's too dangerous. So duplicate the original .../staging/snippets/<dir> to <dir>.original, and modify dir ?
Attachment #519055 - Flags: feedback?(nrthomas) → feedback+
(In reply to comment #3)
> Looks like it would work for when we have no problems with the automation or
> app. 

We assume that the automation works perfect! :) No kidding, what might destroy the snippets? At the moment we have only 2 builders (updates and MU) which upload to this directory.

> What would the workflow be if we have to manually tweak the snippets ? I don't
> want to overwrite any existing directory, that's too dangerous. So duplicate
> the original .../staging/snippets/<dir> to <dir>.original, and modify dir ?

Yeah. AFAIK, we usually follow this work flow if we need to modify snippets even for dated dirs. BTW, the current implementation doesn't allow 2 builds within 1 day.
Attached patch buildbotcustomSplinter Review
Staging tries to upload using the following commands:

rsync -av -e 'ssh -oIdentityFile=~/.ssh/cltbld_dsa' aus2.test/ cltbld@staging-stage.build.mozilla.org:/opt/aus2/snippets/staging/Firefox-4.0b12-build1-test

rsync -av -e 'ssh -oIdentityFile=~/.ssh/cltbld_dsa' aus2.test/ cltbld@staging-stage.build.mozilla.org:/opt/aus2/snippets/staging/Firefox-3.6.14-build3-test

rsync -av -e 'ssh -oIdentityFile=~/.ssh/cltbld_dsa' aus2.test/ cltbld@staging-stage.build.mozilla.org:/opt/aus2/snippets/staging/Firefox-3.5.17-build1-test

rsync -av -e 'ssh -oIdentityFile=~/.ssh/cltbld_dsa' aus2.test/ cltbld@staging-stage.build.mozilla.org:/opt/aus2/snippets/staging/Firefox-3.5.17-build1-3.6.14-build3-MU-test
Attachment #519358 - Flags: review?(nrthomas)
Attachment #519358 - Flags: review?(bhearsum)
Attachment #519055 - Flags: review?(nrthomas)
Attachment #519358 - Flags: review?(bhearsum) → review+
Attachment #519358 - Flags: review?(nrthomas) → review+
Attachment #519055 - Flags: review?(nrthomas) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.