640945 - Don't use dated snippet directory names

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Rail Aliiev [:rail]]

It's very hard to predict the names or use them in automation

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

But we still need something to make the names unique, of only because of build2 and so on. Any suggestions ?

Comment 2

[Rail Aliiev [:rail]]

Attachment: snippet dir name

Nick, what do you think about this? The dir names are not unique per invocation but per build number.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 519055 [details] [diff] [review]
snippet dir name

Looks like it would work for when we have no problems with the automation or app. 

What would the workflow be if we have to manually tweak the snippets ? I don't want to overwrite any existing directory, that's too dangerous. So duplicate the original .../staging/snippets/<dir> to <dir>.original, and modify dir ?

Comment 4

[Rail Aliiev [:rail]]

(In reply to comment #3)
> Looks like it would work for when we have no problems with the automation or
> app. 

We assume that the automation works perfect! :) No kidding, what might destroy the snippets? At the moment we have only 2 builders (updates and MU) which upload to this directory.

> What would the workflow be if we have to manually tweak the snippets ? I don't
> want to overwrite any existing directory, that's too dangerous. So duplicate
> the original .../staging/snippets/<dir> to <dir>.original, and modify dir ?

Yeah. AFAIK, we usually follow this work flow if we need to modify snippets even for dated dirs. BTW, the current implementation doesn't allow 2 builds within 1 day.

Comment 5

[Rail Aliiev [:rail]]

Attachment: buildbotcustom

Staging tries to upload using the following commands:

rsync -av -e 'ssh -oIdentityFile=~/.ssh/cltbld_dsa' aus2.test/ [e-mail]:/opt/aus2/snippets/staging/Firefox-4.0b12-build1-test

rsync -av -e 'ssh -oIdentityFile=~/.ssh/cltbld_dsa' aus2.test/ [e-mail]:/opt/aus2/snippets/staging/Firefox-3.6.14-build3-test

rsync -av -e 'ssh -oIdentityFile=~/.ssh/cltbld_dsa' aus2.test/ [e-mail]:/opt/aus2/snippets/staging/Firefox-3.5.17-build1-test

rsync -av -e 'ssh -oIdentityFile=~/.ssh/cltbld_dsa' aus2.test/ [e-mail]:/opt/aus2/snippets/staging/Firefox-3.5.17-build1-3.6.14-build3-MU-test

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 519055 [details] [diff] [review]
snippet dir name

http://hg.mozilla.org/build/tools/rev/398552e8eae4

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 519358 [details] [diff] [review]
buildbotcustom

http://hg.mozilla.org/build/buildbotcustom/rev/fde615791800