640968 - Start-up crash [@ mozilla::scache::StartupCache::WaitOnWriteThread] when showing profile locked dialog

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Josh Matthews [:jdm]]

This bug was filed from the Socorro interface and is 
report bp-9b6535f7-a1bd-4fe8-a895-cf20a2110310 .
============================================================= 

When attempting to get the Android font list, we end up not null-checking the startup cache (it fails to initialize and clears the global pointer) and crash.

0 	libxul.so 	mozilla::scache::StartupCache::WaitOnWriteThread 	startupcache/StartupCache.cpp:385
1 	libxul.so 	mozilla::scache::StartupCache::GetBuffer 	startupcache/StartupCache.cpp:224
2 	libxul.so 	FontNameCache::FontNameCache 	gfx/thebes/gfxAndroidPlatform.cpp:191
3 	libxul.so 	gfxAndroidPlatform::GetFontList 	gfx/thebes/gfxAndroidPlatform.cpp:435
4 	libxul.so 	gfxAndroidPlatform::UpdateFontList 	gfx/thebes/gfxAndroidPlatform.cpp:470
5 	libxul.so 	gfxAndroidPlatform::gfxAndroidPlatform 	gfx/thebes/gfxAndroidPlatform.cpp:88
6 	libxul.so 	gfxPlatform::Init 	gfx/thebes/gfxPlatform.cpp:278
7 	libxul.so 	nsThebesGfxModuleCtor 	gfx/src/thebes/nsThebesGfxFactory.cpp:130
8 	libxul.so 	nsComponentManagerImpl::KnownModule::Load 	xpcom/components/nsComponentManager.cpp:974
9 	libxul.so 	nsFactoryEntry::GetFactory 	xpcom/components/nsComponentManager.cpp:1948
10 	libxul.so 	nsComponentManagerImpl::CreateInstance 	xpcom/components/nsComponentManager.cpp:1236
11 	libxul.so 	CallCreateInstance 	nsComponentManagerUtils.cpp:158
12 	libxul.so 	nsBaseWidget::BaseCreate 	widget/src/xpwidgets/nsBaseWidget.cpp:219
13 	libxul.so 	nsWindow::Create 	widget/src/android/nsWindow.cpp:197
14 	libxul.so 	nsWebShellWindow::Initialize 	nsCOMPtr.h:800
15 	libxul.so 	nsAppShellService::JustCreateTopWindow 	xpfe/appshell/src/nsAppShellService.cpp:435
16 	libxul.so 	nsAppShellService::CreateTopLevelWindow 	xpfe/appshell/src/nsAppShellService.cpp:231
17 	libxul.so 	nsAppStartup::CreateChromeWindow2 	nsCOMPtr.h:492
18 	libxul.so 	nsWindowWatcher::OpenWindowJSInternal 	embedding/components/windowwatcher/src/nsWindowWatcher.cpp:727
19 	libxul.so 	nsWindowWatcher::OpenWindow 	embedding/components/windowwatcher/src/nsWindowWatcher.cpp:423
20 	libxul.so 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/unix/xptcinvoke_arm.cpp:199
21 	libxul.so 	XPCWrappedNative::CallMethod 	js/src/xpconnect/src/xpcwrappednative.cpp:3124
22 	libxul.so 	XPC_WN_CallMethod 	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1613
23 	libxul.so 	js::Interpret 	js/src/jsinterp.cpp:4801
24 	libxul.so 	js::Invoke 	js/src/jsinterp.cpp:653
25 	libxul.so 	js::ExternalInvoke 	js/src/jsinterp.cpp:863
26 	libxul.so 	JS_CallFunctionValue 	js/src/jsapi.cpp:5173
27 	libxul.so 	nsXPCWrappedJSClass::CallMethod 	js/src/xpconnect/src/xpcwrappedjsclass.cpp:1674
28 	libxul.so 	nsXPCWrappedJS::CallMethod 	js/src/xpconnect/src/xpcwrappedjs.cpp:589
29 	libxul.so 	PrepareAndDispatch 	xpcom/reflect/xptcall/src/md/unix/xptcstubs_arm.cpp:134
30 	libxul.so 	libxul.so@0x93a8c4 	
31 	libxul.so 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/unix/xptcinvoke_arm.cpp:199
32 	libxul.so 	XPCWrappedNative::FindTearOff 	js/src/xpconnect/src/xpcwrappednative.cpp:1966
33 		@0x9 	
34 	libxul.so 	XPCWrappedNative::CallMethod 	js/src/xpconnect/src/xpcwrappednative.cpp:3124
35 	libxul.so 	XPC_WN_CallMethod 	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1613
36 	libxul.so 	js::Invoke 	js/src/jscntxtinlines.h:706
37 	libxul.so 	js_fun_apply 	js/src/jsfun.cpp:2206
38 	libxul.so 	js::Interpret 	js/src/jsinterp.cpp:4801
39 	libxul.so 	js::Invoke 	js/src/jsinterp.cpp:653
40 	libxul.so 	js::ExternalInvoke 	js/src/jsinterp.cpp:863
41 	libxul.so 	JS_CallFunctionValue 	js/src/jsapi.cpp:5173
42 	libxul.so 	nsXPCWrappedJSClass::CallMethod 	js/src/xpconnect/src/xpcwrappedjsclass.cpp:1674
43 	libxul.so 	nsXPCWrappedJS::CallMethod 	js/src/xpconnect/src/xpcwrappedjs.cpp:589
44 	libxul.so 	PrepareAndDispatch 	xpcom/reflect/xptcall/src/md/unix/xptcstubs_arm.cpp:134
45 	libxul.so 	libxul.so@0x93a8c4 	
46 	libxul.so 	ProfileLockedDialog 	toolkit/xre/nsAppRunner.cpp:1886
47 	libxul.so 	libxul.so@0xf100b 	
48 	libxul.so 	XRE_main 	toolkit/xre/nsAppRunner.cpp:2328

Comment 1

[Josh Matthews [:jdm]]

Huh, I don't like that this is one of the more moderate volume of crashes so far.  I wonder why we're hitting the locked profile dialog?

Comment 2

[Josh Matthews [:jdm]]

Attachment: Avoid using null cache if the singleton does not actually exist.

Comment 3

[Scoobidiver (away)]

It is #8 top crasher in 4.0.

See:
https://crash-stats.mozilla.com/report/list?range_value=2&range_unit=weeks&signature=mozilla%3A%3Ascache%3A%3AStartupCache%3A%3AWaitOnWriteThread

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/projects/cedar/rev/157a97622583

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/157a97622583

Comment 6

[Scoobidiver (away)]

It is #7 top crasher in Firefox for mobile 4.0.
What is the threhold to get it fixed for 4.0.1?

Comment 7

[Kevin Brosnan [Ex-Mozilla]]

We would need to respin 4.0.1 builds to take this patch.