Closed
Bug 640980
Opened 14 years ago
Closed 14 years ago
Add generic ARM/NEON detection code
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 583958
People
(Reporter: derf, Assigned: derf)
References
Details
Attachments
(1 file)
|
17.20 KB,
patch
|
Details | Diff | Splinter Review |
We need NEON detection for ARMv7 platforms like the Tegra2 which do not have NEON support, similar to the detection that already exists for SSE, etc., on x86.
Currently, we have detection in pixman, libtheora, libvpx, and jstracer, at the very least. Bug 620526 also added a custom version for YUV2RGB code (which was broken, fixed in bug 637961). We can't do much about the 3rd-party libraries, since they have to work outside of the Mozilla tree, but we should at least centralize our own detection.
The "Add ScaleYCbCrToRGB565" patch in bug 634557 adds such generic detection. I'm breaking it out into this bug for the purposes of tracking and review.
|
Assignee | |
Comment 1•14 years ago
|
||
The code in the attached patch is based on the libtheora/libvpx code (which I wrote). It has been tested on both Maemo and Android, and x86 Linux, and does the right thing in each case. I have not yet tested it on a Tegra2, because I don't have one.
|
|
Assignee | |
Comment 2•14 years ago
|
||
Apparently this is a duplicate of 583958 (I searched, but failed to find it before; thanks to dbaron for pointing it out).
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•