640987 - YUI is only used for the first tabular report when using multiple tables

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect)

Description

[Jonathan Martens]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.15) Gecko/20110303 Firefox/3.6.15
Build Identifier: 

While reporting bug 640985 I noticed that the first result table on landfill is beautified after loading, but subsequent tables are not. Is this intentionally or could this be a regression?

I am observing this using FF 3.6.15

Reproducible: Always

Steps to Reproduce:
Open the report as linked in the URL field and wait a little.
Actual Results:  
First table looks are changed after the page load, subsequent tables are not.

Expected Results:  
All tables should have the newer, nicer look.

Comment 1

[Frédéric Buclin]

Confirmed.

Comment 2

[Guy Pyrzak]

Attachment: v1

i don't like how this JS is included in the template when it doesn't need to be, but this will fix the bug without moving stuff around.

Comment 3

[Max Kanat-Alexander]

Comment on attachment 539411 [details] [diff] [review]
v1

Review of attachment 539411 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine, just one nit:

::: template/en/default/reports/report-table.html.tmpl
@@ +125,4 @@
>        {key:"total", parser:this.parseNumber}
>      ]
>    };
> +  this.myDataTable = new YAHOO.widget.DataTable("tabular_report_container_[% tbl FILTER js %]", myColumnDefs, this.myDataSource, {formatRow: totalRowFormatter});

This line is longer than 80 characters.

Comment 4

[Guy Pyrzak]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/reports/report-table.html.tmpl
Committed revision 7841.

I wasn't sure there was a 4.2 branch but as far as i can tell there isn't., i split the nitted line into 3 lines