641010 - crash [@ libdvm.so@0x35790][@ libdvm.so@0x35748 ][@ libdvm.so@0x35784 ][@ libdvm.so@0x357d0 ]

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Thomas Arend [:tarend]]

This bug was filed from the Socorro interface and is 
report bp-f46cdd8c-4833-47ec-a58e-97bcb2110311 .
============================================================= 
This happens wjen long-tapping on a url and selecting copy

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Sounds like a dupe of bug 640337

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

all these crash reports came in the day after 640337 landed, so I don't think its a dupe.

However, all these crash reports were for one build only, so it looks like it is a dupe of something that landed on 3/10.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

so... resolving works for me since this fell off the crash stats

Comment 4

[Scoobidiver (away)]

It is in 4.0 crash stats:
https://crash-stats.mozilla.com/report/list?range_value=2&range_unit=weeks&signature=libdvm.so%400x35790

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox Mobile 4.0 RC 1 build 3, Android 2.3.3 (Google Nexus)

Copying the url from urlbar causes a crash.

Steps to reproduce:
1. Launch Firefox Mobile.
2. Open a website, e.g. mozilla.com
3. Click into the urlbar to get into edit mode.
4. Click and hold for getting the context menu, choose copy.

A second later or so the applications crashes.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

It also happens in a new profile create with the 'Mobile Profiles' extension. Here is the crash from my default profile: https://crash-stats.mozilla.com/report/index/7fc2f882-249b-4447-be41-c609c2110329

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This happens also using the Link2Clipboard extension which simply copies a link url to the clipboard (before crashing). So sound like a clipboard issue (in Fennec or Android).

Comment 8

[Josh Matthews [:jdm]]

Archaeopteryx, where can Link2Clipboard be found?  I don't see it when searching on AMO.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Wasn't yet visible as no editor hadn't yet reviewed it. You find it here:
https://addons.mozilla.org/mobile/addon/link2clipboard/

Comment 10

[Scoobidiver (away)]

I added other related crash signatures to the summary.
With combined signatures, it is a virtual #16 top crasher in 4.0 over the last 3 days.

More reports at:
https://crash-stats.mozilla.com/query/query?product=Fennec&version=Fennec%3A4.0&platform=linux&branch=2.0&range_value=1&range_unit=weeks&query_search=signature&query_type=startswith&query=libdvm.so@0x357&build_id=&process_type=any&hang_type=any&do_query=1

Comment 11

[Josh Matthews [:jdm]]

Doug/Brad, could this be a result of a missing |AutoLocalJNIFrame jniFrame;| in AndroidBridge::SetClipboardText?

Comment 12

[Doug Turner (:dougt)]

wouldn't that result in a java crash?

Comment 13

[Aaron Train [:aaronmt]]

(In reply to comment #5)
> Firefox Mobile 4.0 RC 1 build 3, Android 2.3.3 (Google Nexus)
> 
> Copying the url from urlbar causes a crash.
> 
> Steps to reproduce:
> 1. Launch Firefox Mobile.
> 2. Open a website, e.g. mozilla.com
> 3. Click into the urlbar to get into edit mode.
> 4. Click and hold for getting the context menu, choose copy.
> 
> A second later or so the applications crashes.

I reproduced this, albeit once on today's nightly 05/03. Still seems like an issue, as Aakash points out http://input.mozilla.com/en-US/opinion/2011891

Comment 14

[Doug Turner (:dougt)]

Program received signal SIGSEGV, Segmentation fault.
0x80035790 in dvmMarkObjectNonNull () from /builds/android_tools/tegra-gdb-20100902/lib/libdvm.so
(gdb) bt
#0  0x80035790 in dvmMarkObjectNonNull () from /builds/android_tools/tegra-gdb-20100902/lib/libdvm.so
#1  0x80052060 in ?? () from /builds/android_tools/tegra-gdb-20100902/lib/libdvm.so
#2  0x80052060 in ?? () from /builds/android_tools/tegra-gdb-20100902/lib/libdvm.so


nothing on adb logcat.


Looks like we are passing back a string to java that isn't null terminated.  patching coming up....

Comment 15

[Doug Turner (:dougt)]

Attachment: patch v.1

I went through the file looking for other uses and also found a few places where we don't have a jni frame on the stack.  I fixed that up.

Comment 16

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/9eae975b3d6f

Comment 17

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 534613 [details] [diff] [review]
patch v.1

android-only crash fix

Comment 18

[Scoobidiver (away)]

From today, we are in Firefox 6 Aurora.
If this patch is wanted for Firefox 5 mobile, it should be landed on Beta.

Comment 19

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 534613 [details] [diff] [review]
patch v.1

Android-only. Wanted for Fx5.

Comment 20

[Doug Turner (:dougt)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/9eae975b3d6f

Comment 21

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/releases/mozilla-beta/rev/0ba4cd9abe00