Closed Bug 641170 Opened 13 years ago Closed 10 years ago

remove AutoIdRooter

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32
Tracking Status
firefox32 --- fixed

People

(Reporter: gal, Assigned: cpeterson)

Details

Attachments

(2 files)

The stack scanner takes care of this. All this does is slow us down.
Attached patch patchSplinter Review
Assignee: general → gal
Attachment #518909 - Flags: review?(wmccloskey)
Attachment #518909 - Flags: review?(wmccloskey) → review+
Terrence: Andreas forgot to land this r+'d patch from 2011 to remove AutoIdRooter. I had to rebase his patch because most uses of AutoIdRooter have since been removed except its class definition and JSTracer.
Assignee: gal → cpeterson
Status: NEW → ASSIGNED
Attachment #8415779 - Flags: review?(terrence)
Comment on attachment 8415779 [details] [diff] [review]
remove-AutoIdRooter-v2.patch

Review of attachment 8415779 [details] [diff] [review]:
-----------------------------------------------------------------

Great! It's nice to see this go.
Attachment #8415779 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/5c399b6e1368
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.