Closed Bug 641195 Opened 9 years ago Closed 9 years ago

Make about:licence work again, or remove the vestiges of it (about:license is not affected)

Categories

(Core :: DOM: Navigation, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla7

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 322000 introduced about:licence in addition to about:license. It uses the same html page, with a correctSpelling() function.

During a large component registration rewrite, bug 568691 removed the contract (or whatever it is called) of about:licence, i.e. the line corresponding to this one in nsDocShellModule.cpp:
{ NS_ABOUT_MODULE_CONTRACTID_PREFIX "license", &kNS_ABOUT_REDIRECTOR_MODULE_CID },

about:licence is no longer listed in about:about, and entering it in the location bar results in an error dialog. about:license works fine.

So we should either add the above mentioned line for "licence" as well.
Or remove the vestiges of "about:licence" from nsAboutRedirector.cpp:
  { "licence", "chrome://global/content/license.html",
    nsIAboutModule::URI_SAFE_FOR_UNTRUSTED_CONTENT },
and remove correctSpelling() and the "correctme" classes from license.html.

Fight for the correct spelling, or remove the bloat?
I originally wrote this code, and I'd like to see it fixed :-)

Gerv
Steffen: it doesn't sound to be like this patch would be complicated. Are you able to make it?

Sadly, it's probably too late for FF4...

Gerv
Attached patch fix it (obsolete) — Splinter Review
Just the one line I mentioned in comment 0 already.
Assignee: nobody → steffen.wilberg
Status: NEW → ASSIGNED
Attachment #519222 - Flags: review?(benjamin)
I really don't like having to maintain two variants, although removing one was an oversight on my part originally. Since none of the other names of about: URIs are localized, I really don't see why this one should be. I think we should remove all the supporting bits of the licence variant.
None of the names are localized into other languages, because about: URIs are specified in English. However this is the only one using a word whose spelling differs between British (and Canadian, Australian and Indian) English and US English. about:license is correct for you, about:licence is correct for me.

This is a small demonstration of the Mozilla project's non-US-centredness, and I would like it to be retained.

(Of course, in hindsight, we would have called it "about:licensing" way back, and avoided this problem. But here we are.)

Gerv
Renaming it to about:licensing would be simple, and it would still be accessible through the About dialog and about:about even if you don't know about the name change.

However, it would break correctSpelling(), which checks if it was loaded as about:license or about:licence. But that's a questionable idea anyway: it's called e.g. the "GNU General Public License", not Licence. The text of the licenses don't get "corrected", only the license titles and some introductory notes.

But if we remove correctSpelling(), the mere doubling of the page location is pretty moot, isn't it?
I agree with Benjamin - this folly needs to stop :) The "small demonstration of the Mozilla project's non-US-centredness" is not worth the code it requires.
OK; let's remove about:license and leave about:licence. :-)

Gerv
Attachment #519222 - Flags: review?(benjamin) → review-
Attached patch nuke itSplinter Review
Sorry Gerv...
Attachment #519222 - Attachment is obsolete: true
Attachment #540597 - Flags: review?(benjamin)
Attachment #540597 - Flags: review?(benjamin) → review+
Merged:
http://hg.mozilla.org/mozilla-central/rev/8be930c2f3c2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
in-testsuite-, no need to test the removal of about:licence.
Flags: in-testsuite? → in-testsuite-
Blocks: 538926
You need to log in before you can comment on or make changes to this bug.