641217 - Paste / contextmenu does not work in password fields

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:
1. Copy text to the clipboard.
2. Long-tap on an <input type="password"> field in Fennec.

Expected results: Context menu with "Paste" option.
Actual results: No context menu.

Originally reported here: https://support.mozilla.com/en-US/questions/792018

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This patch will cause the textbox context menu to appear for password fields, but without the "copy" commands.

Note: mozIsPassword excludes password fields when the argument is "true."
http://mxr.mozilla.org/mozilla-central/source/dom/interfaces/html/nsIDOMHTMLInputElement.idl#128

Comment 2

[Matt Brubeck (:mbrubeck)]

Nominated for blocking because (a) copying passwords from email to the browser was a very common use case given in requests for copy/paste, and (b) the attached patch is straightforward and low-risk.  This is also a parity issue.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 518945 [details] [diff] [review]
patch

Seems low risk and the use case is definitely a good one.

Comment 4

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mobile-browser/rev/ccbaa34fb248

Comment 5

[Anna (Waverley)]

VERIFIED FIXED on:

Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre) Gecko/20110315 Firefox/4.0b13pre Fennec /4.0b6pre 

Devices: Motorola Droid 2 (Android 2.2), HTC Desire(Android 2.2),
         Nokia N900 (Linux Maemo GTK)