HTMLElement.getElementsByTagName broken with foreign children

RESOLVED FIXED

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

7 years ago
This case was missed in bug 499656.
(Assignee)

Comment 1

7 years ago
Created attachment 518948 [details] [diff] [review]
Fix HTMLElement.getElementsByTagName with foreign children
Attachment #518948 - Flags: review?(Olli.Pettay)
(Assignee)

Updated

7 years ago
Whiteboard: [needs patch] → [needs review]
Comment on attachment 518948 [details] [diff] [review]
Fix HTMLElement.getElementsByTagName with foreign children

Perhaps Jonas could review this too.
Attachment #518948 - Flags: review?(Olli.Pettay) → review?(jonas)
Why not simply remove the method?
Comment on attachment 518948 [details] [diff] [review]
Fix HTMLElement.getElementsByTagName with foreign children

Can't you completely remove this function and instead just let it be inherited?

r=me with that fixed.
Attachment #518948 - Flags: review?(jonas) → review+
(Assignee)

Comment 5

7 years ago
Created attachment 519199 [details] [diff] [review]
Patch for checkin

OK, thanks.
Attachment #518948 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Depends on: 610267
Whiteboard: [needs review] → [needs landing]
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Whiteboard: [needs landing]
(Assignee)

Comment 6

7 years ago
Created attachment 522106 [details] [diff] [review]
Patch for checkin
Attachment #519199 - Attachment is obsolete: true
http://hg.mozilla.org/projects/cedar/rev/0e831a3686fb
Whiteboard: fixed-in-cedar
Flags: in-testsuite+

Comment 8

7 years ago
http://hg.mozilla.org/mozilla-central/rev/0e831a3686fb
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
No longer depends on: 610267
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
You need to log in before you can comment on or make changes to this bug.