Closed Bug 641330 Opened 12 years ago Closed 12 years ago

maxrows="10" doesn't work

Categories

(SeaMonkey :: Search, defect)

Product:
SeaMonkey
Component:
Search
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking2.0 Macaw+, status2.0 .1-fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.1final
Tracking Flags:
Tracking Status
blocking2.0 --- Macaw+
status2.0 --- .1-fixed

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

Proposed patch [Checked in: Comment 3 & 6]
2.11 KB, patch
iannbugzilla
: review+
dveditz
: approval2.0+
Details | Diff | Splinter Review 
The SeaMonkey search bar uses a toolkit autocomplete binding for the search box but an xpfe autocomplete binding for the search popup. This means that the maxrows setting does not propagate.
Assignee: nobody → neil
Status: NEW → ASSIGNED

        Attachment #519009 -
        Flags: review?(iann_bugzilla)

    
    

    
  
Comment on attachment 519009 [details] [diff] [review]
Proposed patch
[Checked in: Comment 3 & 6]

No sign of xpfe autocomplete disappearing soon then?

        Attachment #519009 -
        Flags: review?(iann_bugzilla) → review+

    
    

    
  
Pushed changeset 2a2956f3eb47 to mozilla-central.

(In reply to comment #2)
> No sign of xpfe autocomplete disappearing soon then?
At best, it will move to suite when Thunderbird stops depending on it.

    
    

    
  
Comment on attachment 519009 [details] [diff] [review]
Proposed patch
[Checked in: Comment 3 & 6]

Want this on the 2.0 branch because we're hoping to release from it, and this is SeaMonkey code (not part of Firefox) that still lives in Mozilla for now.

        Attachment #519009 -
        Flags: approval2.0?

    
  
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b3

    
    

    
  
Comment on attachment 519009 [details] [diff] [review]
Proposed patch
[Checked in: Comment 3 & 6]

Approved for the mozilla2.0 repository, a=dveditz for release-drivers

        Attachment #519009 -
        Flags: approval2.0? → approval2.0+
blocking2.0: --- → Macaw

        Attachment #519009 -
        Attachment description: Proposed patch → Proposed patch
[Checked in: Comment 3]

    
    

    
  
Transplanted from mozilla-central onto releases/mozilla2.0:

  http://hg.mozilla.org/releases/mozilla-2.0/rev/a5edb74598d5

          status2.0:
          --- → .1-fixed
Target Milestone: seamonkey2.1b3 → seamonkey2.1final

        Attachment #519009 -
        Attachment description: Proposed patch
[Checked in: Comment 3] → Proposed patch
[Checked in: Comment 3 & 6]

          You need to log in
          before you can comment on or make changes to this bug.