641333 - Remove nsIDOM3Text

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 519011 [details] [diff] [review]
Patch v1

Put a blank line after splitText in the idl, and r=me

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Will do.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

Patch to fix

I accidentally rewrote this patch having forgotten that ms2ger already had. However turns out this was a good thing as he's telling me that his patch doesn't quite work.

So here is mine :)

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 534495 [details] [diff] [review]
Patch to fix

>--- a/content/base/src/nsGenericDOMDataNode.cpp
>+++ b/content/base/src/nsGenericDOMDataNode.cpp
>+nsGenericDOMDataNode::ReplaceWholeText(const nsAString& aContent,
>+  SetText(aContent.BeginReading(), aContent.Length(), PR_TRUE);
>+  return CallQueryInterface(this, aResult);
>+
>+  return NS_OK;
> }

The latter return should surely go.

>diff --git a/dom/interfaces/core/nsIDOM3Text.idl b/dom/interfaces/core/nsIDOM3Text.idl
>--- a/dom/interfaces/core/nsIDOM3Text.idl
>+++ b/dom/interfaces/core/nsIDOM3Text.idl

Why not remove the file altogether?

>diff --git a/dom/interfaces/core/nsIDOMText.idl b/dom/interfaces/core/nsIDOMText.idl
>--- a/dom/interfaces/core/nsIDOMText.idl
>+++ b/dom/interfaces/core/nsIDOMText.idl
>@@ -42,14 +42,38 @@
> /**
>  * The nsIDOMText interface inherits from nsIDOMCharacterData and represents 
>  * the textual content (termed character data in XML) of an Element or Attr.
>  *
>  * For more information on this interface please see 
>  * http://www.w3.org/TR/DOM-Level-2-Core/
>  */

Link to a more recent spec, perhaps?

>diff --git a/js/src/xpconnect/src/dom_quickstubs.qsconf b/js/src/xpconnect/src/dom_quickstubs.qsconf
>--- a/js/src/xpconnect/src/dom_quickstubs.qsconf
>+++ b/js/src/xpconnect/src/dom_quickstubs.qsconf
>-    'nsIDOM3Text_': {
>-        'thisType': 'nsGenericTextNode'
>-        },
>-    'nsIDOM3Text_IsElementContentWhitespace': {
>-        'thisType': 'nsGenericTextNode',
>-        'code': '    PRBool result = self->IsElementContentWhitespace();',
>-        'canFail': False
>-        },
>-    'nsIDOM3Text_ReplaceWholeText': {
>-        'thisType': 'nsGenericTextNode',
>-        'code': '    nsIContent* result = '
>-                'self->ReplaceWholeText(PromiseFlatString(arg0), &rv);'
>-        },

Did this code even work, without having those methods listed in the members array?

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

You probably need to rev the CDATASection uuid too, but looks good to me otherwise. Do make sure it builds and passes tests, though :)

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in

http://hg.mozilla.org/mozilla-central/rev/111ca3e50989

Thanks for the review!