Closed
Bug 641366
Opened 13 years ago
Closed 13 years ago
Remove Tiger's entry in CellRenderSettings
Categories
(Core :: Widget: Cocoa, defect)
Core
Widget: Cocoa
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file)
|
4.61 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
Since bug 548097, we use only the first row in CellRenderSetting.margins... which is actually the one with Tiger's values. That's unfortunate...
Attachment #519043 -
Flags: review?
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [needs review]
|
|
Assignee | |
Updated•13 years ago
|
Attachment #519043 -
Flags: review? → review?(mstange)
|
||
Updated•13 years ago
|
Attachment #519043 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [needs review] → [can land][post-2.0]
|
|
Assignee | |
Comment 1•13 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/3752e4069aa7
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [can land][post-2.0]
Target Milestone: --- → mozilla2.2
|
||
Comment 2•13 years ago
|
||
Comment on attachment 519043 [details] [diff] [review] Patch v1 > // A multidimensional array of [2][3][4], Really? >- // with the first dimension being the OS version (Tiger or Leopard), >+ // with the first dimension being the OS version (only Leopard for the moment), > // the second being the control size (mini, small, regular), and the third > // being the 4 margin values (left, top, right, bottom). >- float margins[2][3][4]; >+ float margins[1][3][4];
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment fixed here: http://hg.mozilla.org/mozilla-central/rev/7f1ecc7f86e8
You need to log in
before you can comment on or make changes to this bug.
Description
•