641366 - Remove Tiger's entry in CellRenderSettings

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Since bug 548097, we use only the first row in CellRenderSetting.margins... which is actually the one with Tiger's values. That's unfortunate...

Comment 1

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/3752e4069aa7

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 519043 [details] [diff] [review]
Patch v1

>   // A multidimensional array of [2][3][4],

Really?

>-  // with the first dimension being the OS version (Tiger or Leopard),
>+  // with the first dimension being the OS version (only Leopard for the moment),
>   // the second being the control size (mini, small, regular), and the third
>   // being the 4 margin values (left, top, right, bottom).
>-  float margins[2][3][4];
>+  float margins[1][3][4];

Comment 3

[Mounir Lamouri (:mounir)]

Comment fixed here:
http://hg.mozilla.org/mozilla-central/rev/7f1ecc7f86e8