641378 - Crash if I import bookmarks backup in offline mode [@ nsXPCWrappedJS::`scalar deleting destructor''(unsigned int) ]

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[[e-mail]]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0

Firefox crashes if I try to import bookmarks from an json file while disconnected from the internet

Reproducible: Always

Steps to Reproduce:
1.make a json backup file of bookmarks with the bookmarks manager
2.disconnect from internet
3.import the backup file
Actual Results:  
firefox crashes


Also tried this in safe mode without any addons

Comment 1

[AndreiD[QA]]

Works for me on:
Mozilla/5.0 (Windows NT 6.1; rv:2.0b13pre) Gecko/20110313 Firefox/4.0b13pre

*Note: Can you provide more clear steps. After disconnecting the internet, do you run a new profile (without history and bookmarks)?

Comment 2

[[e-mail]]

No it crashed all the times with my old profile.

I think I now found out that it has something to do with Firefox Sync.

I created a new profile, and the error was gone, no crash anymore.

But then I created a new Sync Account, repeated the steps above and it causes Firefox to crash again.

Hope this was helpful.

Comment 3

[Marco Bonardo [:mak]]

did you get the crash reporter dialog and submitted a crash report? Can you please give us the crash id? (you can get it by visiting about:crashes with that profile)

Comment 4

[AndreiD[QA]]

Reproducible on:
Mozilla/5.0 (Windows NT 6.1; rv:2.0b13pre) Gecko/20110313 Firefox/4.0b13pre

*Note: I could reproduce the issue. I got the following crash report:
ID: baa4669c-d476-434a-9557-077be2110314

Comment 5

[Teodosia Pop]

Able to reproduce using Mozilla/5.0 (Windows NT 6.1; rv:2.0b13pre) Gecko/20110313 Firefox/4.0b13pre.
Setting resolution to NEW.

Comment 6

[Marcia Knous [:marcia]]

The stack reported in Comment 4 is the same stack as in Bug 592998.

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1

I don't know how this ever worked. I'm also not entirely sure why this doesn't always crash, but we don't hit this codepath very often. In short, the lesson here is that an nsXPCWrappedJS is not its underlying XPTCStub and calling virtual methods on the wrapped JS doesn't forward correctly.

Peter, another way of fixing this would be to call QI on the returned nsXPCWrappedJS, but I think that's equivalent to this approach. Does it look right to you as well?

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Real patch

Sorry for the spam.

By the way, it seems to me like someone should file a bug on sync throwing exceptions all over the place (and generally not gracefully falling back) when the browser is in offline mode. But that's separate from this.

Comment 9

[Peter Van der Beken [:peterv]]

Comment on attachment 522030 [details] [diff] [review]
Real patch

In the testcase I'd check exception.tries for non-zero.

Comment 10

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/a089731c47d5

Comment 11

[Vlad [QA]]

Verified fixed on Mozilla/5.0 (Windows NT 6.1; rv:2.2a1pre) Gecko/20110411 Firefox/4.2a1pre