641421 - Default view isn't selected if persisted category item no longer exists

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

1. Add category item via an addon
2. Select that new category item
3. Close addons manager
4. Make addon no longer add the category item
5. Re-open addons manager
6. Persisted category item no longer exists, so no category is selected
7. gCategories breaks because gCategories.node.selectedItem is null (in maybeHideSearch, but probably other places too)
8. No view is loaded because gCategories is broken


Step 4 is a bit iffy, I actually reproduced this by adding the category item too late in the initialization process (ie, not via an overlay).

Also, this (hopefully) won't be an issue once categories are added/discovered via a proper API.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Shouldn't that also work with an installed locale as extension, and uninstalling it from inside the details view?

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #1)
> Shouldn't that also work with an installed locale as extension, and
> uninstalling it from inside the details view?

No, I just checked that, and it falls back to the default view in that case.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ah, right. We simply hide the category but it is still existent.

Comment 4

[Dave Townsend [:mossop]]

Kind of a dupe of bug 595848 but I'm going to take that for the general support and this for the specific issue I think

Comment 5

[Dave Townsend [:mossop]]

This will have been fixed by bug 644704. Tests will be included in bug 595848

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This is not fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a1) Gecko/20110430 Firefox/6.0a1

Updated steps:
1. Open about:config and search for 'extensions.ui.lastCategory'
2. Enter a new value, i.e. addons://list/user-scripts
3. Open the Add-ons Manager

With step 3 we still don't show any category selected.

Comment 7

[Dave Townsend [:mossop]]

Odd, I tried those STR and it showed me the extensions list, though that is not quite what I would have expected so clearly something going on here. I think I might have hit this already in my changes in bug 595848

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Interesting. In a fresh profile I do also see the behavior you have mentioned. The profile I have used before had GreaseMonkey installed before. So I'm not sure if that makes a difference here.

Comment 9

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Dave: This should be fixed now, right?

Comment 10

[Dave Townsend [:mossop]]

Yes, fixed by and tested in bug 595848

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with steps from comment 6 and Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a2) Gecko/20110529 Firefox/6.0a2