Closed Bug 641422 Opened 14 years ago Closed 14 years ago

wrong arg passed for current working directory

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- Macaw+
status2.0 --- .1-fixed
status1.9.2 --- unaffected
status1.9.1 --- unaffected

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

Attachments

(1 file)

patch rev1
752 bytes, patch
mossop
: review+
dveditz
: approval2.0+
Details | Diff | Splinter Review
patch coming up.
Attached patch patch rev1 — — Splinter Review
Attachment #519073 - Flags: review?(dtownsend)
The tests I am writing in bug 386760 will cover this... the changes are too extensive to reasonably write just a test for this.
Attachment #519073 - Flags: review?(dtownsend) → review+
blocking2.0: --- → ?
I really hate it when people nominate things for blocking without explanation. Minusing until rationale comes through.
blocking2.0: ? → -
Sorry about that. The problem statement is in the summary and is, "wrong arg passed for current working directory". What that means is that the current working directory will be incorrect after an update. The fix is safe / simple in that the patch changes the code so the correct arg is passed for the current working directory.
blocking2.0: - → ?
I should also mention that I asked for blocking-2.0 to get .x approval
Ask for approval, for now that's done using the approval2.0 flag.
blocking2.0: ? → -
Thanks... just so you know, I did that for bug 635161 and the approval request was removed and the blocking-2.0=.x flag was granted. Might be a good thing to send out a notice to this affect if one hasn't been sent out already.
Attachment #519073 - Flags: approval2.0?
Comment on attachment 519073 [details] [diff] [review] patch rev1 Approved for mozilla2.0 repository, a=dveditz for release-drivers
Attachment #519073 - Flags: approval2.0? → approval2.0+
blocking2.0: - → Macaw
status2.0: --- → wanted
btw: I'll land this on mozilla-central Monday so leaving open. The tests in bug 386760 also test this bug.
Pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/3ac2e9681421 This is tested by the tests in bug 386760.
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: