641477 - Throw UNSPECIFIED_EVENT_TYPE_ERR if event isn't initialized before dispatching

Status: NEW

(Core :: DOM: Events, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

This is way more complicated than I was hoping for, but
we just didn't have EventException.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: hopefully even with all the new files

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to comment #1)
> Created attachment 519160 [details] [diff] [review]
> patch
> 
> This is way more complicated than I was hoping for, but
> we just didn't have EventException.

And we shouldn't have added it without a use case.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

I don't understand that comment.
I think there was an agreement how
event creation/dispatch should work; throw exception if the
event isn't initialized before dispatching.

And the use case is sane API.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Throwing an exception is fine, implementing EventException is unnecessary bloat.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Well, that is what the current specification requires, and that
is what is implemented in other engines.

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

At least Google [1], and I assume Opera as well, are willing to change, and Doug hasn't replied to the feedback yet. It seems rather strange to implement it now, given that the spec has required it for over a decade.

[1] http://lists.w3.org/Archives/Public/www-dom/2011JanMar/0078.html

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Well, which error code should be thrown?
Currently Web DOM Core doesn't seem to define that case at all.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/22a798b4a012

This anyway now fixed. But if there will be a spec
which specifies some other error code and deprecates EventException,
I'd be happy to back out that and implement the new approach.

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://bitbucket.org/ms2ger/dom-core/changeset/6b9047b5ad06#chg-Overview.src.html

What do you think?