http://tinderbox.mozilla.org/showlog.cgi?log=Build-System/1300146319.1300147692.28039.gz Rev3 WINNT 5.1 build-system opt test mochitest-other on 2011/03/14 16:45:19 s: talos-r3-xp-042 541 INFO TEST-START | /tests/modules/plugin/test/test_pluginstream_seek_close.html 542 ERROR TEST-UNEXPECTED-FAIL | /tests/modules/plugin/test/test_pluginstream_seek_close.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - frameLoaded is not defined at http://mochi.test:8888/tests/modules/plugin/test/test_pluginstream_seek_close.html:1 543 INFO TEST-PASS | /tests/modules/plugin/test/test_pluginstream_seek_close.html | We didn't crash 544 INFO TEST-END | /tests/modules/plugin/test/test_pluginstream_seek_close.html | finished in 93ms
To actually apply this, you'll probably need the dos2unix of it that I'll be pushing under it.
Attachment #519342 - Flags: review?(benjamin)
Comment on attachment 519342 [details] [diff] [review] Fix Why not move the SimpleTest.waitForExplicitFinish bit up to the top also? I can't see how it would hurt, and then you don't have another script.
Attachment #519342 - Flags: review?(benjamin) → review+
http://hg.mozilla.org/mozilla-central/rev/d0ae270d1758 http://hg.mozilla.org/mozilla-central/rev/afc698d16615 I had the vague leftover feeling that there had been some reason why I didn't want to put the waitForExplicitFinish in the head, but I couldn't come up with what it might have been.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.