Fix folder structure for the API rewrite

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [module-refactor])

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
We have to update our folders to match the new structure of the mozmill-tests repository:

http://hg.mozilla.org/qa/mozmill-tests/file/default

Lets do that in milestone 2.
(Assignee)

Comment 1

8 years ago
I will take it.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
(Assignee)

Comment 2

8 years ago
Created attachment 526175 [details] [diff] [review]
Patch v1

Moves all the files to the appropriate folders as discussed earlier today.
Attachment #526175 - Flags: review?(gmealer)
Comment on attachment 526175 [details] [diff] [review]
Patch v1

Looks fine, but two comments before you do any checkins:

First, we should probably get rid of the whimboo subdir I put in--all of that code has been addressed at this point, and it causes doc artifacts when we run jsdoc-toolkit against modules/lib. 

At the very least, we should move it out to be whimboo/lib, whimboo/tests rather than what I had, tests/whimboo and lib/whimboo. That way it won't be part of the docgen. But I'd say just nuke it; we don't need it.

Second, we can't do this as a patch, though I understand it was convenient to review it that way (sorta -- I'd actually have preferred to review this as a github branch, since adding/deleting files is harder to get an overview of in patch form). 

But the merge itself needs to use git mv and then git merge or we'll lose change history on all files moved. Please do not apply this as a patch.

With those notes in mind, r=me.
Attachment #526175 - Flags: review?(gmealer) → review+
(Assignee)

Comment 4

8 years ago
(In reply to comment #3)
> First, we should probably get rid of the whimboo subdir I put in--all of that
> code has been addressed at this point, and it causes doc artifacts when we run
> jsdoc-toolkit against modules/lib. 

At this state I would like to keep at least my files from the lib folder. So I would move those up to the root for the time being (probably next 2 weeks). Then we can get rid of those. The tests have already been deleted, because they haven't added any value.

> But the merge itself needs to use git mv and then git merge or we'll lose
> change history on all files moved. Please do not apply this as a patch.

That's what I will do.

I will get it in soon.
(Assignee)

Comment 5

8 years ago
Landed as:
https://github.com/geoelectric/mozmill-api-refactor/commit/90f030f409d87101d342081a7a85ed47cdb6b362

As you can see even with 'git mv' the history is not available on GitHub. But that really is a github only issue. The history of the files are preserved and you can reach it by using i.e. 'git log --follow lib/api/assertions.js'
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Good to know. Thanks for the warning re: github history.
(Assignee)

Comment 7

8 years ago
That should probably also solve the question with patch, which shouldn't make any difference.
You need to log in before you can comment on or make changes to this bug.