Last Comment Bug 641852 - Disable nib-stripping in Camino/prefPanes and Sparkle
: Disable nib-stripping in Camino/prefPanes and Sparkle
Status: RESOLVED FIXED
:
Product: Camino Graveyard
Classification: Graveyard
Component: General (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: ---
Assigned To: Smokey Ardisson (offline for a while; not following bugs - do not email)
:
Mentors:
Depends on:
Blocks: 514495
  Show dependency treegraph
 
Reported: 2011-03-15 08:51 PDT by Chris Peterson [:cpeterson]
Modified: 2011-03-22 18:31 PDT (History)
2 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Disables nib-stripping for Camino, prefPanes, and Sparkle (4.46 KB, patch)
2011-03-15 13:47 PDT, Smokey Ardisson (offline for a while; not following bugs - do not email)
stuart.morgan+bugzilla: superreview+
phiw2: feedback+
Details | Diff | Review

Description Chris Peterson [:cpeterson] 2011-03-15 08:51:41 PDT
Disable nib-stripping in Camino/prefPanes and Sparkle. There's no reason for us not to be doing that per bug 514495 comment 22 anyway. Since Sparkle still hasn't fixed their nib, turning stripping off in-tree removes one small level of hack needed for building on 10.6.
Comment 1 Chris Peterson [:cpeterson] 2011-03-15 08:52:13 PDT
Blocks bug 514495.
Comment 2 Smokey Ardisson (offline for a while; not following bugs - do not email) 2011-03-15 13:47:09 PDT
Created attachment 519501 [details] [diff] [review]
Disables nib-stripping for Camino, prefPanes, and Sparkle

This should do what we want to do.

1) It should get the stripping-fails-on-SUStatus.nib-with-Xcode-3.something-on-10.6 fix into the tree, complete with README update.

2) It should ensure that a theoretical Camino release built on 10.6 would produce unstripped nibs for Camino, prefPanes, and Sparkle, so that l10n could take our release build and run l10n tools on the nibs to localize (Breakpad.nib is localized entirely from strings, with layout adjustment done in code, so no need to change Breakpad).  This is more future-proofing than anything else, but it makes sense to do it while we're thinking about it.

To test the whole fix, someone on 10.6 would need to 1) build all the way through? (at the very least ensure Sparkle is entirely rebuilt) and 2) test that each prefPane's nib and an assortment of nibs in Camino.app/Contents/Resources/Englihs.lproj/ and Camino.app/Contents/Frameworks/Sparkle.framework/Versions/A/Resources/en.lproj will open in Interface Builder following the build.

philippe, can you take this for a spin?
Comment 3 philippe (part-time) 2011-03-15 21:26:07 PDT
Comment on attachment 519501 [details] [diff] [review]
Disables nib-stripping for Camino, prefPanes, and Sparkle

* Patch builds without problems (both 10.4u and 10.5sdk, in both cases all the way through - make -f client.mk clean, etc )
* I successfully opened all Preference Pane nibs, the Sparkle nibs and a random number of other nibs in Camino.app/Contents/Resources/English.lproj/ for both builds
* both builds are fully functional, preference panes open correctly, etc.
Comment 4 Stuart Morgan 2011-03-22 16:30:38 PDT
Comment on attachment 519501 [details] [diff] [review]
Disables nib-stripping for Camino, prefPanes, and Sparkle

sr=smorgan

Long term we want to strip Sparkle though don't we, since localizations come from upstream anyway?
Comment 5 Smokey Ardisson (offline for a while; not following bugs - do not email) 2011-03-22 16:45:36 PDT
(In reply to comment #4)
> Comment on attachment 519501 [details] [diff] [review]
> Disables nib-stripping for Camino, prefPanes, and Sparkle
> 
> sr=smorgan
> 
> Long term we want to strip Sparkle though don't we, since localizations come
> from upstream anyway?

Many of the Sparkle localizations go upstream from Camino's localizers, actually.

But our third-party code localization story is messy, given how Cocoa l10n tools work and the fact we strip l10ns from our build (Sparkle) or don't have them in the tree at all (Breakpad).  We'll have to sort out these issues along with the ones in http://wiki.caminobrowser.org/User:Sardisson/Towards_a_single_Camino_binary when we get there.
Comment 6 Smokey Ardisson (offline for a while; not following bugs - do not email) 2011-03-22 18:31:49 PDT
http://hg.mozilla.org/camino/rev/b315902eb2c4

Everyone remember to remove the Sparkle patch from bug 514495 before updating your tree(s).

Note You need to log in before you can comment on or make changes to this bug.