Closed Bug 641854 Opened 10 years ago Closed 10 years ago

Use nsIStringBundle API for formatting strings

Categories

(Firefox for Android Graveyard :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 4.0

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
We missed (or added by mistake) a string formatting call that uses the wrong API. Results in:

Warning: WARN addons.manager: InstallListener threw exception when calling onInstallEnded: TypeError: strings.getFormattedString is not a function
Source File: chrome://browser/content/extensions.js
Line: 937

Don't be fooled, this is an error and could be keeping the add-ons manager from properly clearing updates.
Attachment #519421 - Flags: review?(mbrubeck)
Attachment #519421 - Flags: review?(mbrubeck) → review+
Comment on attachment 519421 [details] [diff] [review]
patch

low risk patch that could also fix some UI issues while updating add-ons
Attachment #519421 - Flags: approval2.0?
Attachment #519421 - Flags: approval2.0? → approval2.0+
pushed:
http://hg.mozilla.org/mobile-browser/rev/1f1e7d646564
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified Fixed:
Mozilla/5.0 (Android; Linux armv71; rv2.0b13pre) Gecko/20110316 Firefox/4.0b13pre Fennec/4.0b6pre
Device: Droid 2 
OS: Android 2.2


Steps to reproduce : 
1. on build 20110315 go to people.mozilla.com/~nhirata/fennec/addons/
2. install fennec-sample-a.xpi
3. restart when asked
4. when fennec comes back up, go to control panel -> addons manager
5. select update
6. go to the error console and look at the warnings.

Expected: no warnings
Actual: 
Warning: WARN addons.manager: InstallListener threw exception when calling
onInstallEnded: TypeError: strings.getFormattedString is not a function
Source File: chrome://browser/content/extensions.js
Line: 937

Note: the plugin is mfinkle's I just modded it so that it works with the more recent builds of fennec.
Status: RESOLVED → VERIFIED
Target Milestone: --- → Firefox 4.0
bugspam
Assignee: nobody → mark.finkle
You need to log in before you can comment on or make changes to this bug.