Closed Bug 641869 Opened 14 years ago Closed 14 years ago

Make quicksearch help page compliant with WAI

Categories

(Bugzilla :: User Interface, enhancement)

Product:
Bugzilla
Component:
User Interface
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 4.4

People

(Reporter: fdonalisio, Assigned: fdonalisio)

References

(Depends on 1 open bug, Blocks 2 open bugs)

Details

(Keywords: access)

Attachments

(1 file, 5 obsolete files)

Remove WCAG 2.0 violations in the quicksearch help page
854 bytes, patch
timello
: review+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101206 Ubuntu/10.10 (CK-IBM) (CK-IBM) Firefox/3.6.13 Build Identifier: We should change the quicksearch help page to make it complaint with W3C Web Accessibility Initiative. Reproducible: Always
Blocks: bz-WAI
Depends on: 641866
Blocks: 641872
Implements the following W3C accessibility techniques: -Using label elements to associate text labels with form controls http://www.w3.org/TR/WCAG20-TECHS/H44.html -Using h1-h6 to identify headings http://www.w3.org/TR/WCAG20-TECHS/H42.html
Attachment #519458 - Flags: review?(timello)
Implements the following W3C accessibility techniques: -Using label elements to associate text labels with form controls -Separating information and structure from presentation to enable different presentations http://www.w3.org/TR/WCAG20-TECHS/G140.html
Assignee: ui → francsd
Attachment #519458 - Attachment is obsolete: true
Attachment #519458 - Flags: review?(timello)
Attachment #521804 - Flags: review?(timello)
Comment on attachment 521804 [details] [diff] [review] Remove WCAG 2.0 violations in the quicksearch help page >=== modified file 'template/en/default/pages/quicksearch.html.tmpl' >@@ -28,17 +28,19 @@ > > [% USE Bugzilla %] > >-<p>Type in one or more words (or pieces of words) to search for:</p> >+<p> >+<label for="quicksearch">Type in one or more words (or pieces of words) to search for:</label> Nit: This line is too long. And indent properly <label> within <p> > >-<h2>The Basics</h2> >+<span class="qs_header">The Basics</span> We need to put a space before this header. <h2> was doing that, visually. > > <ul class="qs_help"> > <li>If you just put a word or series of words in the search box, >@@ -92,7 +94,7 @@ > <p>You may also want to read up on the <a href="#advanced">Advanced > Features</a>.</p> > >-<h2 id="fields">Fields You Can Search On</h2> >+<span class= "qs_header" id="fields">Fields You Can Search On</span> Same here. Certify that the <span> will have the same visual. > >-<h2 id="advanced">Advanced Features</h2> >+<span class="qs_header" id="advanced">Advanced Features</span> Here. > > <ul class="qs_help"> > <li>If you want to search for a <strong>phrase</strong> or something that >@@ -189,7 +191,7 @@ > </li> > </ul> > >-<h2 id="shortcuts">Advanced Shortcuts</h2> >+<span class="qs_header" id="shortcuts">Advanced Shortcuts</span> And here.
Attachment #521804 - Flags: review?(timello) → review-
Attachment #521804 - Attachment is obsolete: true
Attachment #523636 - Flags: review?(timello)
Comment on attachment 523636 [details] [diff] [review] Remove WCAG 2.0 violations in the quicksearch help page Review of attachment 523636 [details] [diff] [review]: ----------------------------------------------------------------- ::: template/en/default/pages/quicksearch.html.tmpl @@ +39,5 @@ > <input type="submit" value="Search" id="find"> > </form> > > +<br> > +<span class="qs_header">The Basics</span> Actually, we should be using <div> and not <span>. <h2> is a block element and <span> is inline. Then we probably won't need the <br>. @@ +94,4 @@ > <p>You may also want to read up on the <a href="#advanced">Advanced > Features</a>.</p> > > +<span class= "qs_header" id="fields">Fields You Can Search On</span> Nit: unnecessary space after class= @@ +145,5 @@ > </tbody> > </table> > > +<br> > +<span class="qs_header" id="advanced">Advanced Features</span> Use <div> instead. @@ +192,4 @@ > </li> > </ul> > > +<span class="qs_header" id="shortcuts">Advanced Shortcuts</span> Use <div> instead.
Attachment #523636 - Flags: review?(timello) → review-
Implements the following W3C accessibility techniques: -Using label elements to associate text labels with form controls -Separating information and structure from presentation to enable different presentations http://www.w3.org/TR/WCAG20-TECHS/G140.html
Attachment #523636 - Attachment is obsolete: true
Attachment #537822 - Flags: review?(timello)
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: access
Comment on attachment 537822 [details] [diff] [review] Remove WCAG 2.0 violations in the quicksearch help page Review of attachment 537822 [details] [diff] [review]: ----------------------------------------------------------------- ::: template/en/default/pages/quicksearch.html.tmpl @@ +39,4 @@ > <input type="submit" value="Search" id="find"> > </form> > > +<br> instead of adding a <br> why don't we put a 'margin' property in the 'qs_header' class?
Attachment #537822 - Flags: review?(timello) → review-
Attachment #537822 - Attachment is obsolete: true
Attachment #552467 - Flags: review?(timello)
Comment on attachment 552467 [details] [diff] [review] Remove WCAG 2.0 violations in the quicksearch help page It looks good! Also it passes in all tests. There's a very minimal visual difference because it removed the <br> and added the margin-top, but it overall it has same result.
Attachment #552467 - Flags: review?(timello) → review+
Flags: approval?
Comment on attachment 552467 [details] [diff] [review] Remove WCAG 2.0 violations in the quicksearch help page >=== modified file 'template/en/default/pages/quicksearch.html.tmpl' >-<h2>The Basics</h2> >+<div class="qs_header">The Basics</div> What's wrong with using <h2> here and elsewhere in this template? They are really titles. I don't understand the logic behind these changes.
Francisco, please update the patch.
Flags: approval?
Comment on attachment 552467 [details] [diff] [review] Remove WCAG 2.0 violations in the quicksearch help page In fact, there is no problem with <h2> for the titles.
Attachment #552467 - Flags: review+ → review-
Attachment #552467 - Attachment is obsolete: true
Attachment #591824 - Flags: review?(timello)
Comment on attachment 591824 [details] [diff] [review] Remove WCAG 2.0 violations in the quicksearch help page Thanks. It looks good.
Attachment #591824 - Flags: review?(timello) → review+
Flags: approval?
Flags: approval4.2?
It's really an enhancement, not a bug, so not accepted for 4.2rc2.
Flags: approval?
Flags: approval4.2?
Flags: approval4.2-
Flags: approval+
Target Milestone: --- → Bugzilla 4.4
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified template/en/default/pages/quicksearch.html.tmpl Committed revision 8109.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: