641884 - Download plugin content shown in fennec

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Doug Turner (:dougt)]

Attachment: screen shot of content

Fennec does not support plugins currently.  When viewing a document that has an embed, object, or applet element, fennec display content that suggests that you can download that plugin.

This is misleading.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch that hides content

Comment 2

[Doug Turner (:dougt)]

we should figure out what we want when plugins are not found.  This patch does the easiest thing we possible can do -- it simply hides the webcontent.  This is not ideal because we can screw up page layout.

Maybe we should show a unhappy plugin face and say something like "plugins do not work on Fennec".

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Madhava - Opinions on this patch? The current patch will cause the blocks of
Flash to collapse, changing the layout of the page. We could just make the
blocks hidden, but not collapsed.

We could also think of a different message.

Comment 4

[Madhava Enros [:madhava]]

I think the current presentation of the block makes sense, though the icon and message should change -- agreed.

We have some new "unhappy plugin" icons for the OOPP case on desktop - I'll have a look at those to see if any are appropriate.

As for the text -- what is the current situation? Do we not support _any_ plugins? Or just specific ones?

Comment 5

[Madhava Enros [:madhava]]

This is the icon I'm thinking of:
http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/pinstripe/mozapps/plugins/contentPluginCrashed.png?force=1

Would we need to do an SVG version to get around zooming/rescaling issues? Or maybe that will just work better in the future.

Comment 7

[Doug Turner (:dougt)]

madhava, not sure we want to reuse the crash icon.  maybe we should do something similar -- maybe with a big X through it?  maybe it doesn't make a difference?

Comment 8

[Brian Dils [:briandils]]

To an everyday user, I feel like the whole plugin thing is hard to understand in the first place. I think we need to be as explicit as possible when explaining why content isn't showing up. Is that going to be a total pain in the ass as far as localization goes?

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

I'd rather we stay focused on getting plugins supported

Comment 10

[Doug Turner (:dougt)]

its going to be many releases before we have plugin support.  i think we should clean this up.

Comment 11

[BMO Automation]

Closing all opened bug in a graveyard component