too many compiler warnings in Cocoa widgets

RESOLVED FIXED

Status

()

Core
Widget: Cocoa
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Josh Aas, Assigned: Josh Aas)

Tracking

Trunk
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

10.89 KB, patch
BenWa
: review+
Benjamin Smedberg
: review+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
We've built up a pretty large number of compiler warnings in Cocoa widget code. It's getting hard to see when new warnings come up. We should clean things up. This bug isn't necessarily about getting rid of *all* warnings, but we should make things significantly better.
(Assignee)

Comment 1

7 years ago
Created attachment 519486 [details] [diff] [review]
fix v1.0

This gets rid of just about everything that isn't a deprecated Apple API warning.
Attachment #519486 - Flags: review?(b56girard)
Comment on attachment 519486 [details] [diff] [review]
fix v1.0

Yay, less warnings! Patch is good.
Attachment #519486 - Flags: review?(b56girard) → review+
(Assignee)

Comment 3

7 years ago
This actually removes *all* warnings for 64-bit. Haven't seen that in years :)
(Assignee)

Comment 4

7 years ago
Comment on attachment 519486 [details] [diff] [review]
fix v1.0

Requesting review from bsmedberg for xpcom changes.
Attachment #519486 - Flags: review?(benjamin)

Updated

7 years ago
Attachment #519486 - Flags: review?(benjamin) → review+
(Assignee)

Comment 5

7 years ago
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/c2f9c8bad8af
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.