641986 - Hide NS_ERROR_FILE_NOT_FOUND failure message if log file cannot be found

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Crowd Extension, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: NS_ERROR_FILE_NOT_FOUND Screenshot

On start of a test-run during the init stage, the following error is produced.

Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFileInputStream.init]

See screenshot

Comment 1

[Aaron Train [:aaronmt]]

This was triggered during endurance_testrun's when setup was expecting a --screenshot-path which isnt available.

Comment 2

[Aaron Train [:aaronmt]]

I'm going to double check to confirm tomorrow, I'll reopen if I was wrong, but so far it's the case.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As said on IRC yesterday I will fix this message even we can't tell the user why we failed exactly.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

This patch makes sure that we delete the formerly log file and don't throw a failure message when it cannot be found after a testrun. That only happens when the testrun fails, i.e. run the add-ons testrun without trusted add-ons checked.

Comment 5

[Aaron Train [:aaronmt]]

Comment on attachment 519890 [details] [diff] [review]
Patch v1

Looks fine, thanks

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed as:
https://github.com/whimboo/mozmill-crowd/commit/ea61c74e1905bd72ba1d71365ce2d663bfedd2e5