642097 - Exact tracing for LivePoolNode

Status: RESOLVED FIXED

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P3)

Description

[Lars T Hansen]

Attachment: Patch

LivePoolNode is a trivial GCRoot subclass that can benefit from exact tracing; it also serves as a test case for the exact tracing for GCRoots and generated tracers for GCRoots.

Comment 1

[Ruchi Lohani]

what's the reason that its moved out of AvmCore? Otherwise looks good.

Comment 2

[Lars T Hansen]

(In reply to comment #1)
> what's the reason that its moved out of AvmCore? Otherwise looks good.

I should have noted that in the comment.  The reason it moved is that the tracer generator script has no facility yet to deal with nested classes.

We could in principle hack around that: if a nested class definition is seen before or inside the DATA section of the outer class then the script could emit the proper qualified class name.  That would probably handle 99% of the cases in practice: there's rarely a need for a nested class if there are no data fields of that type, ergo the definition will appear before or inside the DATA section of the outer class.

The other possible fix is to have a variant of the GC_CPP_EXACT directive that takes an additional parameter, the name of the nesting class.  This would handle 100% of the cases without any mystery.  (GC_CPP_NESTED_EXACT?)

Comment 3

[Tamarin Bot]

changeset: 6104:9234130b3c1c
user:      Lars T Hansen <[e-mail]>
summary:   Fix 642097 - Exact tracing for LivePoolNode (r=rulohani, pending)

http://hg.mozilla.org/tamarin-redux/rev/9234130b3c1c