642140 - nsEventDispatcher should dispatch chrome only events to TabChildGlobal

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

With this change using NS_EVENT_FLAG_ONLY_CHROME_DISPATCH does the right thing,
IMO, which is that the event is also dispatched to tabglobal.

We could even add a helper method to nsIPrivateDOMEvent to set that flag,
if needed.

Will upload to tryserver

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Apparently there is still something wrong with the patch.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Bah, DispatchChromeEvent isn't quite like NS_EVENT_FLAG_ONLY_CHROME_DISPATCH.
The first one dispatched to chrome event handler, the latter one
just makes sure the event isn't dispatched to content.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: simpler

Need to do just this for now, and I'll then file a followup to figure out
if we should change DispatchChromeEvent.

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 519709 [details] [diff] [review]
simpler

r=jst. Any way we can test this?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

There is a hackish way, I think, using a drop event and dragSession.
I'll write the test before pushing.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: +tests

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/9906280eeef7