Closed Bug 642140 Opened 9 years ago Closed 9 years ago

nsEventDispatcher should dispatch chrome only events to TabChildGlobal

Categories

(Core :: DOM: Events, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(3 files)

Attached patch patchSplinter Review
With this change using NS_EVENT_FLAG_ONLY_CHROME_DISPATCH does the right thing,
IMO, which is that the event is also dispatched to tabglobal.

We could even add a helper method to nsIPrivateDOMEvent to set that flag,
if needed.

Will upload to tryserver
Apparently there is still something wrong with the patch.
Bah, DispatchChromeEvent isn't quite like NS_EVENT_FLAG_ONLY_CHROME_DISPATCH.
The first one dispatched to chrome event handler, the latter one
just makes sure the event isn't dispatched to content.
Attached patch simplerSplinter Review
Need to do just this for now, and I'll then file a followup to figure out
if we should change DispatchChromeEvent.
Attachment #519709 - Flags: review?(jst)
Comment on attachment 519709 [details] [diff] [review]
simpler

r=jst. Any way we can test this?
Attachment #519709 - Flags: review?(jst) → review+
There is a hackish way, I think, using a drop event and dragSession.
I'll write the test before pushing.
Depends on: 644565
Attached patch +testsSplinter Review
http://hg.mozilla.org/mozilla-central/rev/9906280eeef7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.