642220 - Fallback update fails on Windows Vista

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

I'm not sure why this is only happening on Windows Vista, but 3.6.15 -> 4.0rc1 is failing to install a fallback update.  This is not reproducible manually so it would seem to be an issue with Mozmill.

There doesn't appear to be much information as these failures are not pushed to brasstacks.  The following is the only errors I have to go on:

testFallbackUpdate\test2.js | testFallbackUpdate_ErrorPatching
testFallbackUpdate\test2.js | teardownModule
testFallbackUpdate\test3.js | testFallbackUpdate_AppliedAndNoUpdatesFound

Again, this only happens on Windows Vista (7 and XP seem to be unaffected).

Comment 1

[u279076]

I was able to find the results in brasstacks for the failures:
http://mozmill-release.brasstacks.mozilla.com/#/update/detail?branch=All&channel=betatest&from=2011-03-09&to=2011-03-16&target=3.6.15

NOTE: 3.5.17 -> 4.0rc1 are unaffected as well.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I can reproduce it on qa-horus in the XP and Vista VM but not with Win7. Also it is only a problem on 1.9.2 but not 1.9.1 or 2.0.

This has been caused by bug 642220. Lets figure out how we can finally fix it now.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Lets see if we can get it somehow fixed with a solution on bug 646643.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

This patch fixes the problem on those Windows machines and enables the update log at the same step.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Backport (1.9.2)

Comment 6

[u279076]

Comment on attachment 524540 [details] [diff] [review]
Patch v1

>- *   Henrik Skupin <[e-mail]>
>+ *   Henrik Skupin <[e-mail]>

Not sure why it was necessary to change this...

>  * ***** END LICENSE BLOCK ***** */
> 
>+
> // Include required modules

Why the extra newline here?

>+var prefs = require("../../../lib/prefs");
>+
>+
>+const PREF_UPDATE_LOG = "app.update.log";
>+
> 
> function setupModule(module) {

Extra newlines here as well...

>+++ b/tests/update/testDirectUpdate/test3.js
>+ * The Initial Developer of the Original Code is Mozilla Foundation.
>+ * Portions created by the Initial Developer are Copyright (C) 2009
>+ * the Initial Developer. All Rights Reserved.

2011

>+ * Contributor(s):
>+ *   Henrik Skupin <[e-mail]>

Email is different to the ones above. Also, lets add (original author) to be inline with our styleguide.

>diff --git a/tests/update/testFallbackUpdate/test1.js b/tests/update/testFallbackUpdate/test1.js
>  * Contributor(s):
>- *   Henrik Skupin <[e-mail]>
>+ *   Henrik Skupin <[e-mail]>

Email and (original author)?

>+var prefs = require("../../../lib/prefs");
>+
>+
>+const PREF_UPDATE_LOG = "app.update.log";
>+
> 
> function setupModule(module) {

Extra newlines?

>diff --git a/tests/update/testFallbackUpdate/test4.js b/tests/update/testFallbackUpdate/test4.js

Same as above (email, original author, copyright date, and newlines)...

I'm not going to r- on these nits, but if you think they are necessary please make the changes before landing.

Comment 7

[u279076]

Comment on attachment 524541 [details] [diff] [review]
Backport (1.9.2)

Same changes as with the initial (default) patch.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We have sorted out the review comments in real. Nothing which requires a change right now.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/921b923995b1 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/c7fad015bd42 (2.0)
http://hg.mozilla.org/qa/mozmill-tests/rev/dba0315f8741 (1.9.2)

Comment 10

[u279076]

This bug is fixed as per the results here:
http://mozmill-release.brasstacks.mozilla.com/#/update/detail?branch=All&channel=release&from=2011-04-01&to=2011-04-08&target=4.0

I noticed that we still have a failure due to the difference in the updater between branches.  Also, I noticed that the Check Add-on Compatability dialog appeared on Vista for .NET 1.1.  We should see if we can add hooks for both. Should I file a new bug for these?

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

There is no way for us in 1.9.2 so you should uninstall the .net framework or simply make the registry key invalid. The latter one should be safer for now.