Except for Mozilla and Firefox, images should not have words in them as this will create an L10n workload of editing images. Please update images under static/img/en/ (or elsewhere) and remove copy. Convert image into HTML and CSS that is "bulletproof" and can scale to any text. So "GET A DOWNLOAD DAY REMINDER" is put into a div which can scale nicely to smaller and larger amounts of characters.
A small % of "objects" have English text in them.... Example: Crayon Box internet_things/static/objects/large/1755_site_0050.png Example: Hello my name is badge: internet_things/static/feature_objects/1755_Site_0167.png Might not be a big issue?
Component: Other → Firefox for all
QA Contact: other → firefox-for-all
In TBG's opinion, we're not finding this to be a big issue with the text in these two images. We recommend leaving as-is. If Mozilla feels strongly about it, we can address, but we think they are fine. Reassigning to Austin for final resolution.
Assignee: claudia → ozten.bugs
So are the following images unused? download_date.png get_started_btn.png download_day_header.png get_started_sprite.png download_day_reminder.png get_your_results_sprite.png download_firefox.png header.png download_firefox_sprite.png make_your_own.png ff4_presents.png mozff4_presents.png ff4_presents_white.png mozff4_presents_white.png I pointed out two images as examples of a broader concern.... They all have text that should be localized. Even the ones with "Firefox 4" also have the word "presents". Firefox 4 is probably passable, but presents should be localizable. thanks
Assignee: ozten.bugs → claudia
OS: Linux → All
Priority: -- → P1
Hardware: x86 → All
Target Milestone: --- → 1.0
Thanks, Austin - we'll definitely look into these.
Removed two spots where we had english strings in images today. I'm going to be looking at replacing make_your_own.png tomorrow, and whether we need any of the download day buttons anyway.
OK, after a slew of changes, I think we're devoid of english strings in images that aren't either 'mozilla' or 'firefox'. Relevant commits are: https://github.com/mozilla/webifyme/commit/4e607faed4ec35d0f749b8f98e7045928e6a94e4 https://github.com/mozilla/webifyme/commit/37ee3f06d3ad848551c5e6edd3316a016c671598 https://github.com/mozilla/webifyme/commit/c5493772cb16aa1f394e22ae43e407cbceeaac4a https://github.com/mozilla/webifyme/commit/9375c655bc2845ef4e8af853f505fbff4c5c3b39 https://github.com/mozilla/webifyme/commit/48abf8c1cf5df72f5fbde3cbc05d39402e76224a https://github.com/mozilla/webifyme/commit/c9fd0600b20c78d93f92e7051e7bd17c2960bf67 https://github.com/mozilla/webifyme/commit/a5492d34ac924d5afd8905f447fd2833da1c9657
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(In reply to comment #7) Strong work, thanks!
You need to log in before you can comment on or make changes to this bug.