642388 - Description of field days_elapsed missing from global/field-descs.none.tmpl, so it could not be translated

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect, P4)

Description

[Georgi D. Sotirov]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; bg; rv:1.9.2.15) Gecko/20110303 Firefox/3.6.15 ( .NET CLR 3.5.30729; .NET4.0E)
Build Identifier: Bugzilla 4.0

The field days_elapsed, visible for example on the quickserach page, is not defined in global/field-descs.none.tmpl and thus appears with it's original text in localized versions of bugzilla

Reproducible: Always

Steps to Reproduce:
1. Open the refereed URL and select any of the localizations
Actual Results:  
The field appears untranslated

Expected Results:  
The field is translated, as the other ones are

The field just needs to be defined in global/field-descs.none.tmpl

Comment 1

[Marc Schumann [:Wurblzap]]

http://bzr.mozilla.org/bugzilla/trunk/annotate/head:/Bugzilla/Field.pm#L166 indicates that new installations don't even have that field. Did it get dropped at some time? Does it need to be removed, by checksetup.pl, from installations still having it? Or is it the other way round: did bug 302599 omit adding the field to the DEFAULT_FIELDS hash?

Comment 2

[Frédéric Buclin]

No, it's there, see line 1166. It's simply missing from field-descs.none.tmpl.

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

Comment 4

[Marc Schumann [:Wurblzap]]

Comment on attachment 548030 [details] [diff] [review]
patch, v1

Review of attachment 548030 [details] [diff] [review]:
-----------------------------------------------------------------

All right, this seems pretty straightforward :)
Can you please tell me why you're not adding days_elapsed to the DEFAULT_FIELDS hash? I'd like to understand this.

Comment 5

[Frédéric Buclin]

(In reply to comment #4)
> Can you please tell me why you're not adding days_elapsed to the
> DEFAULT_FIELDS hash?

In the early days of Bugzilla, days_elapsed didn't exist, but was a fragment of SQL code, see bug 302599. So Bugzilla::Field::populate_field_definitions() has to treat it a bit differently, as you can see in this method.

Comment 6

[Marc Schumann [:Wurblzap]]

Comment on attachment 548030 [details] [diff] [review]
patch, v1

All right; r=Wurblzap. Perhaps you can add a comment on the hash, then, on check-in? I'd like to see all fields in one place, if possible -- this bug here might not have happened if the hash had told of days_elapsed.

Comment 7

[Frédéric Buclin]

(In reply to comment #6)
> All right; r=Wurblzap. Perhaps you can add a comment on the hash, then, on
> check-in?

I certainly can. :) Nice to see you are still around for reviews. ;)

Comment 8

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Field.pm
modified template/en/default/global/field-descs.none.tmpl
Committed revision 7867.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified template/en/default/global/field-descs.none.tmpl
Committed revision 7621.