bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Status

()

Core
XPCOM
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
mozilla5
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 519868 [details] [diff] [review]
Remove nsStringArray

In bug 474369 and others we've been moving away from nsVoidArray (and nsCStringArray and nsStringArray).

We're now at the point where nsStringArray is no longer used in our code base:

http://mxr.mozilla.org/comm-central/search?string=nsStringArray&regexp=1&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

The only two places which use it:

1) txDOM.h which appears to be some code specific to xlst, but I couldn't actually get xlst to build, so I assume that it is effectively dead.

2) LDAP code in comm-central - this isn't built currently (and I'm possibly going to hg remove it soon anyway).


So although I don't usually like to do things piecemeal, I think we should drop nsStringArray now and stop any other usages of it popping up.

It'll probably take us a while to get rid of nsCStringArray and nsVoidArray (unless someone does another blitz), so this would seem a reasonable compromise for now.
Attachment #519868 - Flags: review?(benjamin)
Flags: in-testsuite-
Sicking, is the txDOM.h stuff dead?
Yes it is. cc'ing peterv in case he feels differently.

Comment 3

7 years ago
Comment on attachment 519868 [details] [diff] [review]
Remove nsStringArray

Amen!
Attachment #519868 - Flags: review?(benjamin) → review+
Blocks: 610267
Checked in: http://hg.mozilla.org/mozilla-central/rev/bbe7d1e967ef
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.