642506 - Use a lightbox for the Watch the Video link on the Firefox home page

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Steven Garrity [:sgarrity]]

Rather than linking to the video on a separate page, John has suggested trying the lightbox for this video.

It's a touch more complicated than our usual lightbox player provided by js/mozilla-video-tools.js because jquery is lazy-loaded after page load for performance reasons on the home page.

Comment 1

[John Slater]

To add to the discussion, I think this is good functionality for the page, but if it affects performance in even a remotely meaningful way we should just wontfix it.

Thanks Steven!

Comment 2

[Michael Gauthier [:gauthierm]]

In r87152, removed some unused css for the video lightbox.

Comment 3

[Michael Gauthier [:gauthierm]]

In r87153, updated video player fallback content to be less dated.

Comment 4

[Michael Gauthier [:gauthierm]]

In r87151, removed JS VideoScaler class. The pages it was used on were specific to Firefox 3.5 and have been removed.

Comment 5

[Steven Garrity [:sgarrity]]

This is done in trunk in r87469 and merged to stage (along with the previous related changes) in r87471.

This applies to the /firefox/new/ and the marketing page variations:

/firefox/new/gamer/
/firefox/new/messaging/
/firefox/new/socialmedia/
/firefox/new/streamer/
/firefox/new/worker

Also re-design the lightbox to better match the new site style and be more awesome.

Comment 6

[raymond [:retornam] (inactive)]

Attachment: screenshot

broken in IE6 and IE7. See attached screenshot

Comment 7

[Michael Gauthier [:gauthierm]]

Bug in Comment 6 fixed in r87535. It affected all browsers that had small viewport heights.

Comment 8

[raymond [:retornam] (inactive)]

(In reply to comment #7)
> Bug in Comment 6 fixed in r87535. It affected all browsers that had small
> viewport heights.
I can  still reproduce the bug

Comment 9

[Steven Garrity [:sgarrity]]

(In reply to comment #8)
> (In reply to comment #7)
> > Bug in Comment 6 fixed in r87535. It affected all browsers that had small
> > viewport heights.
> I can  still reproduce the bug

I can't reproduce this anymore. Are you testing in trunk? What version of IE?

Comment 10

[raymond [:retornam] (inactive)]

(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > Bug in Comment 6 fixed in r87535. It affected all browsers that had small
> > > viewport heights.
> > I can  still reproduce the bug
> 
> I can't reproduce this anymore. Are you testing in trunk? What version of IE?

I am testing on trunk  and I can reproduce the problem. See the screencast below
http://screencast.com/t/xQgrFjthP

Comment 11

[Steven Garrity [:sgarrity]]

An update on this for the 2.2 release cycle - we thought we had this fixed, but raymond is running into a bug that we haven't been able to reproduce yet (or fix, obviously). We'll try to keep debugging today, but until we get it, this one will have to stay out of the 2.2 release.

Comment 12

[Michael Gauthier [:gauthierm]]

There are two separate issues here. In IE6, position: fixed is not supported so the video appears at the bottom of the page.

In other browsers, you can reproduce the original bug by resizing the browser window after the video starts playing.

Comment 13

[John Slater]

I know you guys have already put a lot of work into this, so if we're close let's finish it up. Other than that, this is totally a nice-to-have bug rather than a must-have, so I'm fine with WONTFIXing it and moving on to other stuff. 

What do you think?

Comment 14

[Steven Garrity [:sgarrity]]

(In reply to comment #13)
> I know you guys have already put a lot of work into this, so if we're close
> let's finish it up. Other than that, this is totally a nice-to-have bug rather
> than a must-have, so I'm fine with WONTFIXing it and moving on to other stuff. 
> 
> What do you think?

John, we took it upon ourselves to clean up the styles and behaviour of the lightbox video javascript while we were doing this anyhow. Will be nice to have for other page that need it. We'll wrap it up shortly.

Comment 15

[Michael Gauthier [:gauthierm]]

Both issues should be fixed in r87875. The no-flash-no-video-sadface version is cleaned up as well.

Comment 16

[raymond [:retornam] (inactive)]

qa-verified-trunk https://www-trunk.stage.mozilla.com/en-US/firefox/new/gamer/

Comment 17

[Steven Garrity [:sgarrity]]

Updates merged to stage in r88122.

Comment 18

[James Long (:jlongster)]

Steven, can you give me a list of revisions to push out? This bug is littered with them and I'm not sure which ones have been pushed to stage or not. We can talk over IRC tomorrow about this if you want. Thanks!

Comment 19

[Steven Garrity [:sgarrity]]

(In reply to comment #18)
> Steven, can you give me a list of revisions to push out? This bug is littered
> with them and I'm not sure which ones have been pushed to stage or not. We can
> talk over IRC tomorrow about this if you want. Thanks!

Sure. Things are packaged up into two merges to stage: r87471 and r88122.

Comment 20

[James Long (:jlongster)]

pushed to production r88270

Comment 21

[raymond [:retornam] (inactive)]

verified fixed http://www.mozilla.com/en-US/firefox/new/gamer/