642658 - Switch to postMessage for the page creation

Status: RESOLVED FIXED

(Cloud Services :: Share: Web Client, defect)

Description

[James Burke]

Don't parse fragment ID, use postMessage, and remove the hashchange watcher.

Comment 1

[James Burke]

Attachment: Pointer to pull request

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: patch to send share state to panel

This sends the share state to the panel on tab switch and on popupshowing

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 522828 [details]
Pointer to pull request

On the very first opening of the panel the web content no longer needs to fetch the share state.  Upon acceptance of the panel patch also attached to this bug, the share state is always sent when switching tabs or opening the panel.  Once I finish the patches up, I'll commit the small fix to this branch.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 522892 [details] [diff] [review]
patch to send share state to panel

I'm revoking this patch, it needs a couple more changes.

Comment 5

[James Burke]

OK as long as the on first open the chrome sends the shareState message at the right time: it could be possible that the page takes a bit to load, or in the reopen case, after a day the web conent will reload itself, so I can see where it will need to expicitly ask the chrome for the shareState.

Comment 6

[Philipp von Weitershausen [:philikon]]

Comment on attachment 522892 [details] [diff] [review]
patch to send share state to panel

This patch is also in the wrong bug. This bug is about the web client only. Bug 642655 deals with the chrome bits. (Just FYI when you have an updated patch.)

Comment 7

[Shane Caraveo (:mixedpuppy)]

James, review the commit I did to the bug branch, and see bug 642655 for the chrome side of this.  Then do a pull review again.

Comment 8

[James Burke]

Comment on attachment 522828 [details]
Pointer to pull request

Seeing if I can reuse the existing attachment for review: looked at mixedpuppy's additional commit in the bug branch and looks good to me.

Comment 9

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 522828 [details]
Pointer to pull request

do not merge this until bug 642655 is r+, they need to land together.

Comment 10

[Philipp von Weitershausen [:philikon]]

(In reply to comment #9)
> do not merge this until bug 642655 is r+, they need to land together.

Bug 642655 landed on fx-share, this can be merged now.

Comment 11

[Shane Caraveo (:mixedpuppy)]

landed web content update

https://github.com/mozilla/f1/commit/87e5f645eb57d4ca4ad837b19cae3fbf31883ace