642743 - AOT break in generating glueClassNames

Status: RESOLVED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Damanjit Singh]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.15) Gecko/20110303 Firefox/3.6.15
Build Identifier: 

This is a fix to correctly generate the glueClassNames(in aotABCTypes_builtin struct), that are later used by AOT to find the corresponding C++ types.
The AOT code parses abc and expects to find the same name as present in the nativeClass metadata. Thus the names initialized in aotABCTypes_builtin struct should be the same as specified in abc.
Observed that, in abc, native class names are either unqualified names(e.g. ArgumentErrorClass), or are fully qualified beginning with :: (e.g. ::avmshell::AbstractBaseClass). Thus this change now generates full names if names starts with ::, else it only generates the cppname.

Reproducible: Always

Comment 1

[Damanjit Singh]

Attachment: proposed patch

Comment 2

[Steven Johnson]

Comment on attachment 520151 [details] [diff] [review]
proposed patch

Looks fine, shall I push it for you?

Comment 3

[Damanjit Singh]

Yes, please. Thank-you.

Comment 4

[Steven Johnson]

pushed to TR as 6119:ef3e768ed7c2