643000 - convert nsStateMapEntry from a class to a struct

Status: RESOLVED WONTFIX

(Core :: Disability Access APIs, defect)

Description

[Trevor Saunders (:tbsaunde)]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0b13pre) Gecko/20110318 Firefox/4.0b13pre
Build Identifier: 

It doesn't make much sense for nsStateMapEntry to be a class, it only has one method which is static, and doesn't really  feel like it belongs there.  The only place we create state map entry objects is in a static array.  It would be a lot nicer to conver nsStateMapEntry to a struct and then statically initialize the structs than the current use of a few similar constructors that are hard to distinguish, but fairly different in effect.

Reproducible: Always

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: (wip) convert nsStateMapEntry from a class to a struct

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 520324 [details] [diff] [review]
(wip) convert nsStateMapEntry from a class to a struct

I'm still not sure it makes things clearer. Frankly I don't have suggestions to make it in a way I like.

Comment 3

[alexander :surkov (:asurkov)]

Guys, you're feedback is appreciated.

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 520324 [details] [diff] [review]
(wip) convert nsStateMapEntry from a class to a struct

cancelling review until feedback from other team members

Comment 5

[alexander :surkov (:asurkov)]

wontfix since we take different approach in bug 741398