Closed
Bug 643005
Opened 14 years ago
Closed 14 years ago
Whitelist method calls from post messages in the Panel
Categories
(Cloud Services :: Share: Firefox Client, defect)
Cloud Services
Share: Firefox Client
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philikon, Assigned: philikon)
References
Details
Attachments
(2 files)
19.98 KB,
patch
|
mixedpuppy
:
review+
|
Details | Diff | Splinter Review |
4.34 KB,
patch
|
mixedpuppy
:
review+
|
Details | Diff | Splinter Review |
The addon should create a whitelist of messages it accepts instead of using a property name check on the sharePanel object, since that object has other private properties which should not be callable from the web app.
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → philipp
Assignee | ||
Comment 1•14 years ago
|
||
Physically move all the postMessage handlers next to each other and add some of James's wiki documentation as docstrings where docs were missing. Purely a mechanical change, no behaviour changes.
Next up: adding the whitelist.
Attachment #523451 -
Flags: review?(mixedpuppy)
Updated•14 years ago
|
Attachment #523451 -
Flags: review?(mixedpuppy) → review+
Assignee | ||
Comment 2•14 years ago
|
||
Attachment #523461 -
Flags: review?(mixedpuppy)
Updated•14 years ago
|
Attachment #523461 -
Flags: review?(mixedpuppy) → review+
Assignee | ||
Comment 3•14 years ago
|
||
Part 0: https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/cec7b307a2cb
Part 1: https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/941bb5a103c7
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•