643038 - Firstrun page design should not broken even if &firstrun.heading2; is empty

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[dynamis (Tomoya ASAI)]

Attachment: patch to add clear:both for #content

In short:
Firstrun page design is broken when &firstrun.heading2; is empty.
To avoid this, #content of firstrun page should have "clear:both" style to avoid the broken design.
Or, localizers should set some dummy invisible string for &firstrun.heading2; if they don't want to show the heading. In that case, l10n comment needed (l10n impact).

Details:
In the firstrun page we have #head and #content are sibling:
http://mxr.mozilla.org/mobile-browser/source/chrome/content/firstrun/firstrun.xhtml#68

#head contains h1 and p. h1 have "float:left;" style:
http://mxr.mozilla.org/mobile-browser/source/themes/core/firstRun.css#147
The p will be empty if localizer don't want to show the header text and he set empty string for &firstrun.heading2;
In that case, #content will be shown on the top-right because #content don't have "clear:both;" (or "clear:left;") style.

Comment 1

[dynamis (Tomoya ASAI)]

Without this, ja locale firstrun will be like:
https://bugzilla.mozilla.org/attachment.cgi?id=520158

If ja locale set non empty &firstrun.heading2; the page design will not broken like this but in Japanese we cannot avoid to use longer text than en-US for it and the header text will be too long to be in a line.
No header text is better than the header in 2 lines for Japanese. That's why we set empty string for &firstrun.heading2;.
# In ja we don't write "Welcome to ***" in the software unless it's localized
# product. Just showing the logo is more natural for our culture.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 520352 [details] [diff] [review]
patch to add clear:both for #content

Let's make sure this doesn't break other locales

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/0429ed06c648

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/releases/mobile-2.0/rev/bb3af87ff027

Comment 5

[dynamis (Tomoya ASAI)]

Attachment: fixed ja firstrun page

Comment 6

[dynamis (Tomoya ASAI)]

Attachment: firstrun screenshots of all locale

Comment 7

[dynamis (Tomoya ASAI)]

Thanks taking my patch.
verified with latest nightly on Nexus One (attachment 523490 [details])

(In reply to comment #2)
> Comment on attachment 520352 [details] [diff] [review]
> patch to add clear:both for #content
> 
> Let's make sure this doesn't break other locales

OK for all locales as you see screenshots in attachment 523491 [details]
# width of 3 buttons are not enough and some text overflow for some locales
# but it's not this bug