643164 - Fire MozScrollAreaChanged before "load", not after

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Benjamin Stover (:stechz)]

Currently MozScrollAreaChanged is fired basically as an executeSoon. This causes the "pageshow" and "load" events to be fired before MozScrollAreaChanged. Fennec does scroll changes on the "load" event and keeps track of the size of the page using MozScrollAreaChanged, so we have to use ugly hacks.

Guaranteeing that MozScrollAreaChanged always fires before the load event would make our code cleaner.

Comment 1

[Benjamin Stover (:stechz)]

Attachment: Fire MozScrollAreaChanged before "load", not after

Timothy, do you mind reviewing this?

This patch now does a check to see if it is safe to fire the event (in other
words, if we are not in the middle of a reflow). When a page is loaded,
pending reflows are flushed so I fire the event during the post-reflow
callback instead of waiting for the new event.

I left the old way of doing it and safely exit out if the event is already
flushed. I'm not sure this is necessary.

Comment 2

[Timothy Nikkel (:tnikkel)]

Comment on attachment 520463 [details] [diff] [review]
Fire MozScrollAreaChanged before "load", not after

I didn't even know this event existed, so I'm going to punt this to roc.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

How about just using AddScriptRunner in PostScrolledAreaEvent?

Comment 4

[Benjamin Stover (:stechz)]

Attachment: Fire MozScrollAreaChanged before "load", not after

Nice! Thanks for the idea.

Comment 5

[Benjamin Stover (:stechz)]

Try: http://tbpl.mozilla.org/?tree=MozillaTry&rev=40274f704936

Comment 6

[Benjamin Stover (:stechz)]

Try run was good.

Comment 7

[Benjamin Stover (:stechz)]

Pushed http://hg.mozilla.org/mozilla-central/rev/60009bb7bc82