Closed Bug 643173 Opened 10 years ago Closed 5 years ago

Build warnings in layout/

Categories

(Core :: Layout, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

(Whiteboard: [build_warning][needs review])

Attachments

(1 file)

Attached patch Patch v1Splinter Review
No description provided.
Attachment #520469 - Flags: review?(roc)
Flags: in-testsuite-
Comment on attachment 520469 [details] [diff] [review]
Patch v1

In many of these cases, initializing variables with a default that's probably wrong just means we won't get valgrind warnings if something actually goes wrong.  I think the valgrind warnings are quite useful.

And, in any case, I think these changes should go to appropriate reviewers rather than all be one big patch.
We build with --enable-warnings-as-errors by default and layout/ does not have any warnings. \o/
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
Comment on attachment 520469 [details] [diff] [review]
Patch v1

This patch is no longer relevant because the warnings in layout/ have been fixed.
Attachment #520469 - Flags: review?(roc)
You need to log in before you can comment on or make changes to this bug.