643212 - Add btoa() and atob() to global environment in xpcshell

Status: RESOLVED DUPLICATE of bug 809218

(Core :: XPConnect, enhancement)

Description

[Zack Weinberg (:zwol)]

Attachment: patch

xpcshell doesn't have the base64 encode and decode functions (btoa, atob) that are available in the component environment, or to code running in the context of a window.  This patch adds them.  I wanted to reuse the shims in nsXPConnect.cpp but the necessary header is apparently not visible to xpcshell.cpp, so I gave up and did it with bare JSAPI.  Hopefully correctly.

Comment 1

[Jeff Walden [:Waldo]]

Comment on attachment 520493 [details] [diff] [review]
patch

I think it far better to do whatever signature-munging is necessary to use the canonical implementation here.  That might just be #include "xpcprivate.h", possibly, looking at how window.atob is implemented.  There were a bunch of duplications of this for awhile, then someone went and unified them all, and I am unwilling to see that work undone.

Comment 2

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

This problem appears to be half-way solved.

I find atob and btoa available in xpcshell tests when building with --enable-application=browser, but they are *not* defined in b2g builds.  How is this possible?

Blake, do you have any ideas?

Comment 3

[Richard Newman [:rnewman]]

Jed: are they available from a BackstagePass?

services/common/tests/unit/head_helpers.js
10:let btoa = Cu.import("resource://gre/modules/Log.jsm").btoa;

Comment 4

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Hi, Richard.  Thanks for introducing me to BackstagePass.  I had no idea.  We'll give it a try!

Comment 5

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Bug 809218 appears to have landed the patch for this.  Taking the liberty of closing this bug.  Please re-open if I'm incorrect.