Closed Bug 643217 Opened 9 years ago Closed 9 years ago

Replace "ASSERTION FAILED" message with "Assertion failure" in assembler

Categories

(Core :: JavaScript Engine, defect, trivial)

ARM
Linux
defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: gkw, Assigned: gkw)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

In the assembler, assertion failure messages are labelled as "ASSERTION FAILED". The proposed patch changes it to "Assertion failure" to synchronize with other parts of the js engine and decapitalizes the other labels as well.

ref bug 643213 for an "ASSERTION FAILED" assert and bug 570895 where the side patch fixes nanoassert messages to output "Assertion failure" labels.
Attachment #520495 - Flags: review?(cdleary)
Assignee: general → gary
Status: NEW → ASSIGNED
cdleary, review ping?
Comment on attachment 520495 [details] [diff] [review]
proposed patch against TM changeset c811be25eaad

Stealing the review.  r+ for a trivial consistency patch.  Thanks, Gary.
Attachment #520495 - Flags: review?(cdleary) → review+
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/be3045fcd6fd
Note: not marking as fixed because fixed-in-tracemonkey is not present on the whiteboard.
(In reply to comment #3)
> cdleary-bot mozilla-central merge info:
> http://hg.mozilla.org/mozilla-central/rev/be3045fcd6fd
> Note: not marking as fixed because fixed-in-tracemonkey is not present on the
> whiteboard.

Oops, this was fixed on TM.

https://hg.mozilla.org/tracemonkey/rev/be3045fcd6fd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-tracemonkey
You need to log in before you can comment on or make changes to this bug.