chnage nshttpcompressconv NS_ERROR to NS_WARNING for data input error

RESOLVED FIXED

Status

()

Core
Networking: HTTP
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: mcmanus, Assigned: mcmanus)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
in the presence of an invalid deflate stream nshttpcompressconv generates an assertion via NS_ERROR.. external data should not cause assertions.

a negative test case in the websockets test harness generates this.
(Assignee)

Updated

7 years ago
Assignee: nobody → mcmanus
(Assignee)

Comment 1

7 years ago
Created attachment 520526 [details] [diff] [review]
compress assertion v1
Attachment #520526 - Flags: review?(honzab.moz)
(Assignee)

Updated

7 years ago
Blocks: 640003
Comment on attachment 520526 [details] [diff] [review]
compress assertion v1

r=honzab

Agree.
Attachment #520526 - Flags: review?(honzab.moz) → review+
(Assignee)

Comment 3

7 years ago
http://hg.mozilla.org/mozilla-central/rev/264508dc959b
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Backed out on suspicion of causing Tp4 regression: http://hg.mozilla.org/mozilla-central/rev/25a266b7d18e
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 5

7 years ago
this is cleared of being the tp4 regression (it was 628561).. ready to push
again
(Assignee)

Comment 6

7 years ago
pushed to cedar
http://hg.mozilla.org/projects/cedar/rev/e48f48ad28be
Pushed to m-c
http://hg.mozilla.org/mozilla-central/rev/e48f48ad28be
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.