Closed Bug 643291 Opened 9 years ago Closed 9 years ago

chnage nshttpcompressconv NS_ERROR to NS_WARNING for data input error

Categories

(Core :: Networking: HTTP, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: mcmanus, Assigned: mcmanus)

References

Details

Attachments

(1 file)

in the presence of an invalid deflate stream nshttpcompressconv generates an assertion via NS_ERROR.. external data should not cause assertions.

a negative test case in the websockets test harness generates this.
Assignee: nobody → mcmanus
Attachment #520526 - Flags: review?(honzab.moz)
Blocks: 640003
Comment on attachment 520526 [details] [diff] [review]
compress assertion v1

r=honzab

Agree.
Attachment #520526 - Flags: review?(honzab.moz) → review+
http://hg.mozilla.org/mozilla-central/rev/264508dc959b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Backed out on suspicion of causing Tp4 regression: http://hg.mozilla.org/mozilla-central/rev/25a266b7d18e
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
this is cleared of being the tp4 regression (it was 628561).. ready to push
again
Pushed to m-c
http://hg.mozilla.org/mozilla-central/rev/e48f48ad28be
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.