64331 - [FIX]Modern theme UI fonts (menus, bookmarks, tabs) too small

Status: VERIFIED FIXED

(Core Graveyard :: GFX, defect, P1)

Description

[Warner Young]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; m18) Gecko/20010103
BuildID:    2001010310

This started a couple of weeks ago, I think, but the font used for parts of the
UI (menubar, bookmark menus, dropdowns like the font size list in Prefs,
bookmark property tabs) are now too small to be easily legible.  It looks like
they're in 6pt text.  Changing the DPI setting in Prefs doesn't seem to have any
effect.  The Classic and Blue themes don't have this problem.

Reproducible: Always
Steps to Reproduce:
Switch to Modern theme.

Expected Results:  Expected UI fonts to be same size as corresponding system font.

Comment 1

[Keyser Sose]

This sounds a lot like bug 63316 but only on Windows.. Weird.

Comment 2

[Jure Repinc (JLP)]

No problems here.
Mozilla 2001020320 on Windows 2000.

Comment 3

[Warner Young]

I've found the problem.  If you set the system font for menus in Windows to
Arial, 7pt, then this problem occurs.  It's almost like the Modern theme is
using the same font, but 1 point smaller.  I don't know if this is by design or
if it's a bug, though.

Comment 4

[hangas]

Sending to Hewitt.

Comment 5

[Patty Mac]

I can not reproduce it. It seems working ok on windows (2001-01-12-06-Mtrunk).

Comment 6

[Warner Young]

Patty, I just tried the 2001-01-12-06-Mtrunk build, and I'm still seeing it. 
Did you change your menu font size to 7 point Arial first?  Also, what version
of Windows?  I'm using Windows 98.  I haven't been able test it with other
versions of Windows yet.

Comment 7

[Warner Young]

To clarify, you must change the Menu font in Windows' Display
Properties->Appearance tab for this to occur, not any of the fonts in Mozilla's
prefs.

Comment 8

[Keyser Sose]

Marking NEW as per comments.

Comment 9

[Joe Hewitt (gone)]

This is not a themes bug.  Under windows, Mozilla just seems to render 7pt fonts
a bit too small.  I'm not sure what component this belongs to, but "Views" is
the closest thing in the components list to "platform font rendering" that I can
find.

Comment 10

[Joe Hewitt (gone)]

*** Bug 58297 has been marked as a duplicate of this bug. ***

Comment 11

[Kevin McCluskey (gone)]

Reassigning to Rod.

Comment 12

[rods (gone)]

Ben, could you get this to the correct place?

Comment 13

[Greg Lauckhart]

Attachment: cvs diff of nsDeviceContextWin.diff demonstrating fix

Comment 14

[timeless]

i know i recently made the mistake of checking in // code, but i think it might 
be better to just wrap unused code in |/*,*/| or |#if 0, #endif|, that way cvs 
blame is preserved.

not UI. Compositor?

Comment 15

[Kevin McCluskey (gone)]

Rod could you look at "Greg's" patch and try applying it. It looks like his
patch fixes the font sizing issues for form elements without using the +2point
Kludge.

Set milestone to mozilla0.9.1

Comment 16

[Oliver Merk]

0.8.1 march 27-01 release still exhibits this behavior. Under WinNT4sp6,
changing the [Display> Properties> Appearance> Message Text] size solves the
problem. Hope this helps.

Comment 17

[rods (gone)]

Cool, thanks for the fix will check on it for 0.9.1

Comment 18

[Marc Attinasi]

Rod, has this been tested yout? What have you found? Assuming it tests OK,
please remove the comments from the patch (either remove completly or #if 0 if
you really want that in there for documentation purposes) and then sr=attinasi

Comment 19

[rods (gone)]

fixed

Comment 20

[Warner Young]

Build 2001050104, Win98.  It looks fixed!  Woo-hoo! :)

Comment 21

[Chris Petersen]

Marking verified per last comments